From: NeilBrown <neilb@suse.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: Thomas Graf <tgraf@suug.ch>,
Herbert Xu <herbert@gondor.apana.org.au>,
Network Development <netdev@vger.kernel.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] rhashtable: rename rht_for_each*continue as *from.
Date: Mon, 18 Mar 2019 11:15:02 +1100 [thread overview]
Message-ID: <87mult82d5.fsf@notabene.neil.brown.name> (raw)
In-Reply-To: <CANiq72ncNHCrE+YRePDCPGgKoKYCSL0mwJXP0jBjYP6W4CVSKA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 771 bytes --]
On Sun, Mar 17 2019, Miguel Ojeda wrote:
> On Thu, Mar 14, 2019 at 6:10 AM NeilBrown <neilb@suse.com> wrote:
>>
>> The pattern set by list.h is that for_each..continue()
>> iterators start at the next entry after the given one,
>> while for_each..from() iterators start at the given
>> entry.
>>
>> The rht_for_each*continue() iterators are documented as though the
>> start at the 'next' entry, but actually start at the given entry,
>> and they are used expecting that behaviour.
>> So fix the documentation and change the names to *from for consistency
>> with list.h
>
> Thank you for taking care of the .clang-format changes!
:-) that's what "git grep" is for!
>
> Acked-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Thanks,
NeilBrown
>
> Cheers,
> Miguel
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-03-18 0:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:05 [PATCH 0/3] Three rhashtable improvements NeilBrown
2019-03-14 5:05 ` [PATCH 3/3] rhashtable: rename rht_for_each*continue as *from NeilBrown
2019-03-15 5:49 ` Herbert Xu
2019-03-17 7:50 ` Miguel Ojeda
2019-03-18 0:15 ` NeilBrown [this message]
2019-03-14 5:05 ` [PATCH 1/3] rhashtable: use cmpxchg() in nested_table_alloc() NeilBrown
2019-03-15 5:10 ` Herbert Xu
2019-03-15 6:51 ` NeilBrown
2019-03-20 5:41 ` Herbert Xu
2019-03-14 5:05 ` [PATCH 2/3] rhashtable: don't hold lock on first table throughout insertion NeilBrown
2019-03-14 14:58 ` Paul E. McKenney
2019-03-15 5:47 ` Herbert Xu
2019-03-15 6:46 ` NeilBrown
2019-03-20 5:40 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mult82d5.fsf@notabene.neil.brown.name \
--to=neilb@suse.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).