From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH 0/5] Use common cordic algorithm for b43 Date: Mon, 05 Nov 2018 10:02:17 +0200 Message-ID: <87muqoar5i.fsf@purkki.adurom.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com To: Priit Laes Return-path: In-Reply-To: (Priit Laes's message of "Sat, 3 Nov 2018 11:59:39 +0200") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Priit Laes writes: > b43 wireless driver included internal implementation of cordic > algorithm which has now been removed in favor of library > implementation. > > During the process, brcmfmac was driver was also cleaned. > > Please note that this series is only compile-tested, as I > do not have access to the hardware. > > Priit Laes (5): > lib: cordic: Move cordic macros and defines to header file > brcmfmac: Use common CORDIC_FLOAT macro from lib > brcmfmac: Drop unused cordic defines and macros > b43: Use common cordic algorithm from kernel lib > b43: Drop internal cordic algorithm implementation > > drivers/net/wireless/broadcom/b43/Kconfig | 1 +- > drivers/net/wireless/broadcom/b43/phy_common.c | 47 +------- > drivers/net/wireless/broadcom/b43/phy_common.h | 9 +- > drivers/net/wireless/broadcom/b43/phy_lp.c | 13 +- > drivers/net/wireless/broadcom/b43/phy_n.c | 13 +- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 +- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 +- > include/linux/cordic.h | 9 +- > lib/cordic.c | 23 +--- > 10 files changed, 35 insertions(+), 95 deletions(-) I don't see patch 1 in linux-wireless patchwork: https://patchwork.kernel.org/project/linux-wireless/list/?series=38033&state=* Via which tree are you planning to push these? These could potentially go via my wireless-drivers-next tree (if review goes ok) but I need to have all five patches in patchwork. Also I don't see MAINTAINERS entry for cordic.[c|h], that would be good to have as well. -- Kalle Valo