netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andreas Schwab <schwab@linux-m68k.org>
To: "j.ps\@openmailbox.org" <j.ps@openmailbox.org>
Cc: netdev@vger.kernel.org
Subject: Re: "ss -p" segfaults
Date: Mon, 20 Jul 2015 20:14:17 +0200	[thread overview]
Message-ID: <87mvyqelxi.fsf@igel.home> (raw)
In-Reply-To: <55AD3073.3000302@openmailbox.org> (j.ps@openmailbox.org's message of "Mon, 20 Jul 2015 18:31:31 +0100")

"j.ps@openmailbox.org" <j.ps@openmailbox.org> writes:

> -			free(p->process);
> -			free(p->process_ctx);
> -			free(p->socket_ctx);
> +			if (p->process)
> +				free(p->process);
> +			if (p->process_ctx)
> +				free(p->process_ctx);
> +			if (p->socket_ctx)
> +				free(p->socket_ctx);

free(NULL) is a no-op.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

  reply	other threads:[~2015-07-20 18:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <55AC9E8C.7040200@openmailbox.org>
2015-07-20 17:31 ` "ss -p" segfaults j.ps
2015-07-20 18:14   ` Andreas Schwab [this message]
2015-07-21  9:50 Segmentation fault in iproute2 ss -p (versions 4.0.0, 4.1.0 and 4.1.1) j.ps
2015-07-21  9:54 ` "ss -p" segfaults j.ps
  -- strict thread matches above, loose matches on Subject: below --
2015-07-15 14:09 Marc Dietrich
2015-07-15 15:02 ` Vadim Kochan
2015-07-15 15:12 ` Vadim Kochan
2015-07-15 16:49   ` Rustad, Mark D
2015-07-15 18:52     ` Rustad, Mark D
2015-07-15 18:57       ` Vadim Kochan
2015-07-15 22:22         ` Vadim Kochan
2015-07-16  6:37           ` Marc Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvyqelxi.fsf@igel.home \
    --to=schwab@linux-m68k.org \
    --cc=j.ps@openmailbox.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).