From: Kalle Valo <kvalo-BkwN83ws05HQT0dZR+AlfA@public.gmane.org>
To: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
Cc: Julian Calaby
<julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
chaoming_li-kXabqFNEczNtrwSWzY7KCg@public.gmane.org
Subject: Re: [RFC/RFT 14/15] rtlwifi: Modify files for addition of rtl8723ae
Date: Fri, 14 Sep 2012 09:10:56 +0300 [thread overview]
Message-ID: <87mx0t3zin.fsf@purkki.adurom.net> (raw)
In-Reply-To: <505170C6.8090003-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> (Larry Finger's message of "Thu, 13 Sep 2012 00:36:06 -0500")
Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org> writes:
>> Is this supposed to be bit #29 - I notice that COMP_USB is also bit 29.
>
> Yes, that is OK. One will only be used for PCI-based drivers, and the
> other is obviously for USB. As nearly all the bits of a 32-bit
> quantity are used, I wanted to save one if possible.
>
> In the final version, I'll code this as
>
> #define COMP_USB BIT(29)
> #define COMP_EASY_CONCURRENT COMP_USB
>
> That way will be more obvious.
You could also add a comment explaining it, just to make sure that
everyone understands it.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-14 6:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 20:54 [RFC/RFT 00/15] Add new driver RTL8723AE Larry Finger
2012-09-12 20:54 ` [RFC/RFT 02/15] rtlwifi: rtl8723ae: Add new driver - Part 2 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 03/15] rtlwifi: rtl8723ae: Add new driver - Part 3 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 05/15] rtlwifi: rtl8723ae: Add new driver - Part 5 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 06/15] rtlwifi: rtl8723ae: Add new driver - Part 6 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 07/15] rtlwifi: rtl8723ae: Add new driver - Part 7 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 08/15] rtlwifi: rtl8723ae: Add new driver - Part 8 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 09/15] rtlwifi: rtl8723ae: Add new driver - Part 9 Larry Finger
[not found] ` <1347483294-6943-1-git-send-email-Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2012-09-12 20:54 ` [RFC/RFT 01/15] rtlwifi: rtl8723ae: Add new driver - Part 1 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 04/15] rtlwifi: rtl8723ae: Add new driver - Part 4 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 10/15] rtlwifi: rtl8723ae: Add new driver - Part 10 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 13/15] rtlwifi: rtl8723ae: Add new driver - Part 13 Larry Finger
2012-09-17 21:18 ` [PATCH 02/15] rtlwifi: rtl8723ae: Add new driver - Part 2 Larry Finger
2012-09-17 21:18 ` [PATCH 05/15] rtlwifi: rtl8723ae: Add new driver - Part 5 Larry Finger
2012-09-17 21:18 ` [PATCH 09/15] rtlwifi: rtl8723ae: Add new driver - Part 9 Larry Finger
2012-09-17 21:18 ` [PATCH 13/15] rtlwifi: rtl8723ae: Add new driver - Part 13 Larry Finger
2012-09-17 21:18 ` [PATCH 14/15] rtlwifi: Modify files for addition of rtl8723ae Larry Finger
2012-09-17 21:18 ` [PATCH 15/15] rtlwifi: rtl8192ce: rtl8192cu: rtl8192se: rtl81723ae: Turn on building of the new driver Larry Finger
2012-09-12 20:54 ` [RFC/RFT 11/15] rtlwifi: rtl8723ae: Add new driver - Part 11 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 12/15] rtlwifi: rtl8723ae: Add new driver - Part 12 Larry Finger
2012-09-12 20:54 ` [RFC/RFT 14/15] rtlwifi: Modify files for addition of rtl8723ae Larry Finger
2012-09-13 3:11 ` Julian Calaby
2012-09-13 5:36 ` Larry Finger
[not found] ` <505170C6.8090003-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2012-09-14 6:10 ` Kalle Valo [this message]
2012-09-12 20:54 ` [RFC/RFT 15/15] rtlwifi: rtl8192ce: rtl8192cu: rtl8192se: rtl81723ae: Turn on building of the new driver Larry Finger
2012-09-17 21:18 ` [PATCH 01/15] rtlwifi: rtl8723ae: Add new driver - Part 1 Larry Finger
2012-09-17 21:18 ` [PATCH 03/15] rtlwifi: rtl8723ae: Add new driver - Part 3 Larry Finger
2012-09-17 21:18 ` [PATCH 04/15] rtlwifi: rtl8723ae: Add new driver - Part 4 Larry Finger
2012-09-17 21:18 ` [PATCH 06/15] rtlwifi: rtl8723ae: Add new driver - Part 6 Larry Finger
2012-09-17 21:18 ` [PATCH 07/15] rtlwifi: rtl8723ae: Add new driver - Part 7 Larry Finger
2012-09-17 21:18 ` [PATCH 08/15] rtlwifi: rtl8723ae: Add new driver - Part 8 Larry Finger
2012-09-17 21:18 ` [PATCH 10/15] rtlwifi: rtl8723ae: Add new driver - Part 10 Larry Finger
2012-09-17 21:18 ` [PATCH 11/15] rtlwifi: rtl8723ae: Add new driver - Part 11 Larry Finger
2012-09-17 21:18 ` [PATCH 12/15] rtlwifi: rtl8723ae: Add new driver - Part 12 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx0t3zin.fsf@purkki.adurom.net \
--to=kvalo-bkwn83ws05hqt0dzr+alfa@public.gmane.org \
--cc=Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org \
--cc=chaoming_li-kXabqFNEczNtrwSWzY7KCg@public.gmane.org \
--cc=julian.calaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox