From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yoshinori Sato Subject: Re: [PATCH] sh_eth Add SH7619 support Date: Sat, 02 Aug 2008 11:34:21 -0400 Message-ID: <87myjv77nm.wl%ysato@users.sourceforge.jp> References: <878wvhtynu.wl%ysato@users.sourceforge.jp> <29ab51dc0807312048hfa9cd88pb90d1a7520bb3f99@mail.gmail.com> <871w18ycmr.wl%ysato@users.sourceforge.jp> <20080802073021.GA30041@verge.net.au> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: Nobuhiro Iwamatsu , Jeff Garzik , Nobuhiro Iwamatsu , netdev@vger.kernel.org, linux-sh@vger.kernel.org To: Simon Horman Return-path: In-Reply-To: <20080802073021.GA30041@verge.net.au> Sender: linux-sh-owner@vger.kernel.org List-Id: netdev.vger.kernel.org At Sat, 2 Aug 2008 17:30:22 +1000, Simon Horman wrote: > > On Fri, Aug 01, 2008 at 11:32:28AM -0400, Yoshinori Sato wrote: > > At Fri, 1 Aug 2008 12:48:27 +0900, > > Nobuhiro Iwamatsu wrote: > > > > > > Hi, Sato-san. > > > > > > 2008/8/1 Yoshinori Sato : > > > > SH7619 have same SH7710 ethernet controler. > > > > Add support for sh_eth driver. > > > > > > > > Signed-off-by: Yoshinori Sato > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/net/sh_eth.h b/drivers/net/sh_eth.h > > > > index 45ad1b0..ca3cc5f 100644 > > > > --- a/drivers/net/sh_eth.h > > > > +++ b/drivers/net/sh_eth.h > > > > @@ -143,10 +143,11 @@ > > > > > > > > > > > > > > > > > + > > > > +/* CPU endian from/to EDMAC endian */ > > > > +#if !defined(CONFIG_CPU_SUBTYPE_SH7619) > > > > +#define cpu_to_edmac(x) cpu_to_le32(x) > > > > +#define edmac_to_cpu(x) le32_to_cpu(x) > > > > +#else > > > > +#define cpu_to_edmac(x) cpu_to_be32(x) > > > > +#define edmac_to_cpu(x) be32_to_cpu(x) > > > > +#endif > > > > + > > > > #endif > > > I think that this depends on an endian not CPU dependence. > > > > I agree. > > But I'm no idea. > > Are you have good idea? > > Iwamatsu-san, > > what is the difference between CONFIG_CPU_LITTLE_ENDIAN and > __LITTLE_ENDIAN__ as used in drivers/net/sh_eth.h ? EDMAC endian is no depend CPU endian. -- Yoshinori Sato