From: Jakub Sitnicki <jakub@cloudflare.com>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
Amery Hung <ameryhung@gmail.com>,
netdev@vger.kernel.org, kernel-team@cloudflare.com,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 4/4] selftests/bpf: Remove tests for prologue/epilogue with kfuncs
Date: Wed, 21 Jan 2026 10:49:20 +0100 [thread overview]
Message-ID: <87o6mnthwf.fsf@cloudflare.com> (raw)
In-Reply-To: <d4563561-c507-4876-8a03-40e4dca2a34e@linux.dev> (Martin KaFai Lau's message of "Tue, 20 Jan 2026 15:48:06 -0800")
On Tue, Jan 20, 2026 at 03:48 PM -08, Martin KaFai Lau wrote:
> On 1/19/26 11:53 AM, Jakub Sitnicki wrote:
>> Remove pro_epilogue_with_kfunc test program and its supporting code in
>> bpf_testmod. This test exercised calling kfuncs from prologue and epilogue,
>> which is no longer supported after the switch to direct helper calls.
>
> Is it easy to change it to test calling helper in pro/epilogue?
I gave it a shot and the obstacle is that bpf_cgroup_from_id and
bpf_cgroup_release are not exported symbols, so they can't be referred
to from bpf_testmod. We'd have to move the whole thing to lib/test_bpf
so it's a built-in.
next prev parent reply other threads:[~2026-01-21 9:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-19 19:53 [PATCH bpf-next 0/4] Switch from kfuncs to direct helper calls in prologue/epilogue Jakub Sitnicki
2026-01-19 19:53 ` [PATCH bpf-next 1/4] bpf, verifier: Support direct helper calls from prologue/epilogue Jakub Sitnicki
2026-01-19 22:44 ` Eduard Zingerman
2026-01-20 23:44 ` Martin KaFai Lau
2026-01-19 19:53 ` [PATCH bpf-next 2/4] bpf: net_sched: Use direct helper calls instead of kfuncs in pro/epilogue Jakub Sitnicki
2026-01-19 22:50 ` Eduard Zingerman
2026-01-20 23:45 ` Martin KaFai Lau
2026-01-19 19:53 ` [PATCH bpf-next 3/4] bpf: Remove kfunc support in prologue and epilogue Jakub Sitnicki
2026-01-19 22:55 ` Eduard Zingerman
2026-01-21 9:54 ` Jakub Sitnicki
2026-01-21 17:01 ` Alexei Starovoitov
2026-01-19 19:53 ` [PATCH bpf-next 4/4] selftests/bpf: Remove tests for prologue/epilogue with kfuncs Jakub Sitnicki
2026-01-19 22:56 ` Eduard Zingerman
2026-01-20 23:48 ` Martin KaFai Lau
2026-01-21 9:49 ` Jakub Sitnicki [this message]
2026-01-21 19:13 ` Martin KaFai Lau
2026-01-23 3:10 ` [PATCH bpf-next 0/4] Switch from kfuncs to direct helper calls in prologue/epilogue Amery Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6mnthwf.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@cloudflare.com \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox