From: Petr Machata <petrm@nvidia.com>
To: Kuniyuki Iwashima <kuniyu@google.com>
Cc: Petr Machata <petrm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, <netdev@vger.kernel.org>,
Ido Schimmel <idosch@nvidia.com>,
Breno Leitao <leitao@debian.org>,
Andy Roulin <aroulin@nvidia.com>,
Francesco Ruggeri <fruggeri@arista.com>,
Stephen Hemminger <stephen@networkplumber.org>,
<mlxsw@nvidia.com>
Subject: Re: [PATCH net-next 1/8] net: core: neighbour: Add a neigh_fill_info() helper for when lock not held
Date: Fri, 16 Jan 2026 13:01:19 +0100 [thread overview]
Message-ID: <87o6mt6a0f.fsf@nvidia.com> (raw)
In-Reply-To: <CAAVpQUAoo0JBCPgf_Mc4cO2tpUmn0=Rn7aiUj0Q7HiHWRyoWpA@mail.gmail.com>
Kuniyuki Iwashima <kuniyu@google.com> writes:
> On Wed, Jan 14, 2026 at 1:56 AM Petr Machata <petrm@nvidia.com> wrote:
>
>> @@ -2684,6 +2680,20 @@ static int neigh_fill_info(struct sk_buff *skb, struct neighbour *neigh,
>> return -EMSGSIZE;
>> }
>>
>> +static int neigh_fill_info(struct sk_buff *skb, struct neighbour *neigh,
>> + u32 pid, u32 seq, int type, unsigned int flags)
>> + __releases(neigh->lock)
>> + __acquires(neigh->lock)
>
> nit: Does Sparse complain without these annotations even
> a function has a paired lock/unlock ops ?
Actually it doesn't. Should I respin for this?
next prev parent reply other threads:[~2026-01-16 12:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 9:54 [PATCH net-next 0/8] net: neighbour: Notify changes atomically Petr Machata
2026-01-14 9:54 ` [PATCH net-next 1/8] net: core: neighbour: Add a neigh_fill_info() helper for when lock not held Petr Machata
2026-01-16 7:22 ` Kuniyuki Iwashima
2026-01-16 12:01 ` Petr Machata [this message]
2026-01-19 12:25 ` Petr Machata
2026-01-14 9:54 ` [PATCH net-next 2/8] net: core: neighbour: Call __neigh_notify() under a lock Petr Machata
2026-01-14 9:54 ` [PATCH net-next 3/8] net: core: neighbour: Extract ARP queue processing to a helper function Petr Machata
2026-01-14 9:54 ` [PATCH net-next 4/8] net: core: neighbour: Process ARP queue later Petr Machata
2026-01-14 9:54 ` [PATCH net-next 5/8] net: core: neighbour: Inline neigh_update_notify() calls Petr Machata
2026-01-18 2:26 ` [net-next,5/8] " Jakub Kicinski
2026-01-19 8:51 ` Petr Machata
2026-01-14 9:54 ` [PATCH net-next 6/8] net: core: neighbour: Reorder netlink & internal notification Petr Machata
2026-01-14 9:54 ` [PATCH net-next 7/8] net: core: neighbour: Make one netlink notification atomically Petr Machata
2026-01-14 9:54 ` [PATCH net-next 8/8] net: core: neighbour: Make another " Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6mt6a0f.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=aroulin@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fruggeri@arista.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leitao@debian.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox