From: Thomas Gleixner <tglx@linutronix.de>
To: "Markus Blöchl" <markus@blochl.de>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>
Cc: "Lakshmi Sowjanya D" <lakshmi.sowjanya.d@intel.com>,
"Richard Cochran" <richardcochran@gmail.com>,
"John Stultz" <jstultz@google.com>,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, markus.bloechl@ipetronik.com,
"Markus Blöchl" <markus@blochl.de>
Subject: Re: [PATCH net] net: stmmac: intel: populate entire system_counterval_t in get_time_fn() callback
Date: Sat, 19 Jul 2025 22:00:02 +0200 [thread overview]
Message-ID: <87o6tguf25.ffs@tglx> (raw)
In-Reply-To: <20250713-stmmac_crossts-v1-1-31bfe051b5cb@blochl.de>
On Sun, Jul 13 2025 at 22:21, Markus Blöchl wrote:
> get_time_fn() callback implementations are expected to fill out the
> entire system_counterval_t struct as it may be initially uninitialized.
>
> This broke with the removal of convert_art_to_tsc() helper functions
> which left use_nsecs uninitialized.
Sigh. As I explained in the other thread, the proper fix is to
zero initialize the data structure at the call site and fix this whole
class of issues in one go.
prev parent reply other threads:[~2025-07-19 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-13 20:21 [PATCH net] net: stmmac: intel: populate entire system_counterval_t in get_time_fn() callback Markus Blöchl
2025-07-14 11:02 ` Simon Horman
2025-07-15 23:40 ` patchwork-bot+netdevbpf
2025-07-19 20:00 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6tguf25.ffs@tglx \
--to=tglx@linutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jstultz@google.com \
--cc=kuba@kernel.org \
--cc=lakshmi.sowjanya.d@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=markus.bloechl@ipetronik.com \
--cc=markus@blochl.de \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox