From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90E661F941B for ; Mon, 2 Dec 2024 08:45:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733129114; cv=none; b=S5MLW2kEou2tOjqJYDCvm7x8mvW8cNk7x+sJmUee/MtrbAA7RJHFIs2SbKx23b3yKfh8KC/tX/B/8VM6ThC6OA+4iKTXL4FdGWQykh+ZLTdKPNgcDuJxHCtE9Ykwv2/XWA5wJ9/e8joh0KzWYc2dWtbZbl/k96WQ6zEicmIkdoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733129114; c=relaxed/simple; bh=8uv53xupTrNP2ieMkOQogRXWVx9INQ9I9BIT46nEVHY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=iHICyyOzYOhfrCXrUB+H47Tcin27wo/hKwWLitYgd6UrExB5OYaxfjbLKTH78Mahyj/1VAEceLyyJPjIsfMJLEoxKp3lXFJ3hpf8MB9swH4PZT7PSjMWQ2lYojVCCRn7NiDrgPL21st+UN20OvioGNqlUvKzLLxwJX48ixsQsGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=ratatoskr.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tI23I-0005AI-BF; Mon, 02 Dec 2024 09:45:08 +0100 From: Steffen Trumtrar To: Krzysztof Kozlowski Cc: Dinh Nguyen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-clk@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2 2/4] arm64: dts: agilex5: add gmac nodes In-Reply-To: <14110c3d-4aee-49a9-8cc2-fbeac298f1ff@kernel.org> (Krzysztof Kozlowski's message of "Mon, 25 Nov 2024 11:51:04 +0100") References: <20241125-v6-12-topic-socfpga-agilex5-v2-0-864256ecc7b2@pengutronix.de> <20241125-v6-12-topic-socfpga-agilex5-v2-2-864256ecc7b2@pengutronix.de> <14110c3d-4aee-49a9-8cc2-fbeac298f1ff@kernel.org> User-Agent: mu4e 1.12.7; emacs 30.0.92 Date: Mon, 02 Dec 2024 09:45:07 +0100 Message-ID: <87o71u8odo.fsf@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: s.trumtrar@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org On 2024-11-25 at 11:51 +01, Krzysztof Kozlowski wrote: > On 25/11/2024 11:33, Steffen Trumtrar wrote: > > The Agilex5 provides three Synopsys XGMAC ethernet cores, that can be > > used to transmit and receive data at 10M/100M/1G/2.5G over ethernet > > connections and enables support for Time Sensitive Networking (TSN) > > applications. > > > > Signed-off-by: Steffen Trumtrar > > --- > > arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi | 87 ++++++++++++++++++++++++++ > > 1 file changed, 87 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > > index b1debf0317d0576f7b00200e9593481671183faa..647ccd0b5a66b68fab745d443b975c12d6ce63df 100644 > > --- a/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > > +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5.dtsi > > @@ -141,6 +141,93 @@ soc: soc@0 { > > device_type = "soc"; > > interrupt-parent = <&intc>; > > > > + gmac0: ethernet@10810000 { > > + compatible = "altr,socfpga-stmmac-a10-s10", > > > That's odd compatible, this is not Arria10 SoC, neither Stratix 10. Yes, it is. The socfpga-dwmac.txt says "Arria10/Agilex/Stratix10 SoCs" should use "altr,socfpga-stmmac-a10-s10". So, how to proceed? Adding a "altr,socfpga-stmmac-agilex5" to the binding doc and driver? And converting the txt to yaml, because touched it last? Best regards, Steffen -- Pengutronix e.K. | Dipl.-Inform. Steffen Trumtrar | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686| Fax: +49-5121-206917-5555 |