From: Kalle Valo <kvalo@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Bartosz Golaszewski" <brgl@bgdev.pl>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Chris Morgan" <macromorgan@hotmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Arnd Bergmann" <arnd@arndb.de>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>,
"Peng Fan" <peng.fan@nxp.com>,
"Robert Richter" <rrichter@amd.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Terry Bowman" <terry.bowman@amd.com>,
"Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Alex Elder" <elder@linaro.org>,
"Srini Kandagatla" <srinivas.kandagatla@linaro.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>
Subject: Re: [RFC 7/9] dt-bindings: wireless: ath11k: describe QCA6390
Date: Tue, 09 Jan 2024 11:13:54 +0200 [thread overview]
Message-ID: <87o7duzx65.fsf@kernel.org> (raw)
In-Reply-To: <82a669f5-259d-427c-b290-6fa1470fec79@linaro.org> (Krzysztof Kozlowski's message of "Thu, 4 Jan 2024 16:57:52 +0100")
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:
> On 04/01/2024 14:01, Bartosz Golaszewski wrote:
>
>> diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> index 817f02a8b481..f584c25f4276 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml
>> @@ -16,6 +16,7 @@ description: |
>> properties:
>> compatible:
>> enum:
>> + - pci17cb,1101 # QCA6390
>> - pci17cb,1103 # WCN6855
>>
>> reg:
>> @@ -27,6 +28,19 @@ properties:
>> string to uniquely identify variant of the calibration data for designs
>> with colliding bus and device ids
>>
>> + enable-gpios:
>> + description: GPIO line enabling the ATH11K module when asserted.
>> + maxItems: 1
>> +
>> + vddpmu-supply:
>> + description: VDD_PMU supply regulator handle
>> +
>> + vddpcie1-supply:
>> + description: VDD_PCIE1 supply regulator handle
>> +
>> + vddpcie2-supply:
>> + description: VDD_PCIE2 supply regulator handle
>
> Looks like these are valid only for specific variant, so you should have
> allOf:if:then disallowing other properties when not applicable. The same
> applies for existing properties which might not exist on qca6390.
And it would be good to provide more information in the commit log about
the platforms where this is used, otherwise the context might not be
clear. Or maybe document that in the bindings file, not sure.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-01-09 9:14 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 13:01 [RFC 0/9] PCI: introduce the concept of power sequencing of PCIe devices Bartosz Golaszewski
2024-01-04 13:01 ` [RFC 1/9] arm64: dts: qcom: sm8250: describe the PCIe port Bartosz Golaszewski
2024-01-04 13:01 ` [RFC 2/9] arm64: dts: qcom: qrb5165-rb5: describe the WLAN module of QCA6390 Bartosz Golaszewski
2024-01-04 13:44 ` Dmitry Baryshkov
2024-01-04 15:13 ` Bartosz Golaszewski
2024-01-04 13:01 ` [RFC 3/9] PCI/portdrv: create platform devices for child OF nodes Bartosz Golaszewski
2024-01-06 1:05 ` Jeff Johnson
2024-01-09 14:43 ` Lukas Wunner
2024-01-10 12:55 ` Bartosz Golaszewski
2024-01-10 13:28 ` Lukas Wunner
2024-01-10 16:26 ` Bartosz Golaszewski
2024-01-10 16:41 ` Lukas Wunner
2024-01-10 20:18 ` Bartosz Golaszewski
2024-01-11 10:42 ` Lukas Wunner
2024-01-11 11:09 ` Bartosz Golaszewski
2024-01-11 15:02 ` Lukas Wunner
2024-01-11 16:16 ` Bartosz Golaszewski
2024-01-11 21:43 ` Geert Uytterhoeven
2024-01-12 9:43 ` Bartosz Golaszewski
2024-01-12 9:47 ` Lukas Wunner
2024-01-12 9:43 ` Lukas Wunner
2024-01-17 23:38 ` Rob Herring
2024-01-10 20:41 ` Dan Williams
2024-01-11 12:40 ` Manivannan Sadhasivam
2024-01-11 15:06 ` Lukas Wunner
2024-01-04 13:01 ` [RFC 4/9] PCI: hold the rescan mutex when scanning for the first time Bartosz Golaszewski
2024-01-04 13:01 ` [RFC 5/9] PCI/pwrseq: add pwrseq core code Bartosz Golaszewski
2024-01-06 1:25 ` Jeff Johnson
2024-01-04 13:01 ` [RFC 6/9] dt-bindings: vendor-prefixes: add a PCI prefix for Qualcomm Atheros Bartosz Golaszewski
2024-01-04 14:33 ` Rob Herring
2024-01-04 14:49 ` Sebastian Reichel
2024-01-08 19:10 ` Rob Herring
2024-01-08 19:22 ` Bartosz Golaszewski
2024-01-09 2:56 ` Rob Herring
2024-01-09 9:17 ` Krzysztof Kozlowski
2024-01-09 9:30 ` Bartosz Golaszewski
2024-01-04 13:01 ` [RFC 7/9] dt-bindings: wireless: ath11k: describe QCA6390 Bartosz Golaszewski
2024-01-04 15:57 ` Krzysztof Kozlowski
2024-01-09 9:13 ` Kalle Valo [this message]
2024-01-04 13:01 ` [RFC 8/9] PCI/pwrseq: add a pwrseq driver for QCA6390 Bartosz Golaszewski
2024-01-06 1:31 ` Jeff Johnson
2024-01-09 9:18 ` Kalle Valo
2024-01-09 9:34 ` Chen-Yu Tsai
2024-01-09 10:09 ` Kalle Valo
2024-01-09 10:14 ` Arnd Bergmann
2024-01-09 10:26 ` Chen-Yu Tsai
2024-01-09 10:38 ` Arnd Bergmann
2024-01-09 16:43 ` Kalle Valo
2024-01-09 16:46 ` Arnd Bergmann
2024-01-04 13:01 ` [RFC 9/9] arm64: defconfig: enable the PCIe power sequencing " Bartosz Golaszewski
2024-01-04 15:11 ` [RFC 0/9] PCI: introduce the concept of power sequencing of PCIe devices Sebastian Reichel
2024-01-08 15:24 ` Neil Armstrong
2024-01-08 16:10 ` Bartosz Golaszewski
2024-01-09 4:08 ` Florian Fainelli
2024-01-09 7:08 ` Chen-Yu Tsai
2024-01-09 7:41 ` Manivannan Sadhasivam
2024-01-09 9:29 ` Geert Uytterhoeven
2024-01-09 9:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7duzx65.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bartosz.golaszewski@linaro.org \
--cc=bhelgaas@google.com \
--cc=brgl@bgdev.pl \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=elder@linaro.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=macromorgan@hotmail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=pabeni@redhat.com \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=rrichter@amd.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=terry.bowman@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).