From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
Jakub Kicinski <kuba@kernel.org>,
jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] docs: networking: document NAPI
Date: Thu, 16 Mar 2023 11:29:14 +0100 [thread overview]
Message-ID: <87o7ot9eh1.fsf@toke.dk> (raw)
In-Reply-To: <20230315223044.471002-1-kuba@kernel.org>
Jakub Kicinski <kuba@kernel.org> writes:
> Add basic documentation about NAPI. We can stop linking to the ancient
> doc on the LF wiki.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Looks good, just one nit:
[...]
> +Threaded NAPI
> +-------------
> +
> +Use dedicated kernel threads rather than software IRQ context for NAPI
> +processing. The configuration is per netdevice and will affect all
> +NAPI instances of that device. Each NAPI instance will spawn a separate
> +thread (called ``napi/${ifc-name}-${napi-id}``).
This section starts a bit abruptly. Maybe start it with "Threaded NAPI
is an operating mode that uses dedicated..." or something along those
lines?
Other than that:
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
next prev parent reply other threads:[~2023-03-16 10:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 22:30 [PATCH net-next] docs: networking: document NAPI Jakub Kicinski
2023-03-15 22:46 ` Stephen Hemminger
2023-03-15 22:52 ` Stephen Hemminger
2023-03-15 23:11 ` Jakub Kicinski
2023-03-16 1:36 ` Stephen Hemminger
2023-03-16 22:59 ` Florian Fainelli
2023-03-16 23:07 ` Jakub Kicinski
2023-03-16 23:18 ` Florian Fainelli
2023-03-15 23:12 ` Tony Nguyen
2023-03-15 23:17 ` Jakub Kicinski
2023-03-15 23:19 ` Jakub Kicinski
2023-03-16 0:20 ` Tony Nguyen
2023-03-16 21:27 ` Tony Nguyen
2023-03-16 1:38 ` Stephen Hemminger
2023-03-16 2:58 ` Jakub Kicinski
2023-03-16 12:03 ` Francois Romieu
2023-03-23 0:44 ` Jamal Hadi Salim
2023-03-16 9:50 ` Bagas Sanjaya
2023-03-16 10:29 ` Toke Høiland-Jørgensen [this message]
2023-03-16 21:35 ` Jakub Kicinski
2023-03-16 23:16 ` Florian Fainelli
2023-03-21 0:02 ` Jakub Kicinski
2023-03-21 0:48 ` Stephen Hemminger
2023-03-21 1:19 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ot9eh1.fsf@toke.dk \
--to=toke@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).