From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29438C433FE for ; Wed, 4 May 2022 16:06:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352019AbiEDQJo (ORCPT ); Wed, 4 May 2022 12:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbiEDQJn (ORCPT ); Wed, 4 May 2022 12:09:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A883725C7B; Wed, 4 May 2022 09:06:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4303E60C37; Wed, 4 May 2022 16:06:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 181E5C385A4; Wed, 4 May 2022 16:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651680365; bh=mIu6gvR8TfoKz5CSa/RJWBPrsb5yAhojeG77OoPZbZ8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Lg3a9GYj9QSXNXBy62fQfvr7vDl8PPnqDYyWHWIsWbU5RdJWL7ytXsZqOmne4GJe+ EweVMY6JUHC1e86/QwLT5AofNVt/r3ms1o2lb1SZdyVhGgdjqk6+0OItLliYI5GFWq jTHOLvSPOAEJFWUZvTSg/1ISqlhFfnEWWxLcd+GKHIAtZagtajytritLohV2Zgfos7 OTY3IU+qGg15iV0QVRL1gWbOxnopiOb765IuXAUAco7ibp/f7I21b4Fecle8Sgwe8o sepuRDCrlUuYDUd50nt252yGyNfZpPAnL2yViqgFNf3eOvL9lHoyZJIvNyIQQOHYTF 8BWXghoaCh0Gg== From: Kalle Valo To: Dan Carpenter Cc: Stefano Brivio , Jaehee , =?utf-8?B?SsOpcsO0bWU=?= Pouiller , "David S. Miller" , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Outreachy Linux Kernel Subject: Re: [PATCH] wfx: use container_of() to get vif References: <20220418035110.GA937332@jaehee-ThinkPad-X1-Extreme> <87y200nf0a.fsf@kernel.org> <20220504093347.GB4009@kadam> <20220504135059.7132b2b6@elisabeth> <20220504132551.GD4009@kadam> Date: Wed, 04 May 2022 19:05:57 +0300 In-Reply-To: <20220504132551.GD4009@kadam> (Dan Carpenter's message of "Wed, 4 May 2022 16:25:51 +0300") Message-ID: <87o80d9tay.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dan Carpenter writes: > On Wed, May 04, 2022 at 01:50:59PM +0200, Stefano Brivio wrote: >> And that it's *obvious* that container_of() would trigger warnings >> otherwise. Well, obvious just for me, it seems. > > :P > > Apparently it wasn't obvious to Kalle and me. My guess is that you saw > the build error. Either that or Kalle and I are geezers who haven't > looked at container_of() since before the BUILD_BUG_ON() was added five > years ago. Exactly, I also had to duplicate the error myself before I was able to understand the issue. So I'm officially a geezer now :D -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches