From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Ahern <dsahern@gmail.com>, Jason Wang <jasowang@redhat.com>,
David Ahern <dsahern@kernel.org>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
David Ahern <dahern@digitalocean.com>
Subject: Re: [PATCH RFC net-next] virtio_net: Relax queue requirement for using XDP
Date: Wed, 26 Feb 2020 10:02:03 +0100 [thread overview]
Message-ID: <87o8tlzppw.fsf@toke.dk> (raw)
In-Reply-To: <20200226034004-mutt-send-email-mst@kernel.org>
"Michael S. Tsirkin" <mst@redhat.com> writes:
> On Wed, Feb 26, 2020 at 09:34:51AM +0100, Toke Høiland-Jørgensen wrote:
>> we already do block some reconfiguration if an XDP program is loaded
>> (such as MTU changes), so there is some precedence for that :)
> Do we really block MTU changes when XDP is loaded?
> Seems to work for me - there's a separate discussion going
> on about how to handle MTU changes - see
> https://lore.kernel.org/r/7df5bb7f-ea69-7673-642b-f174e45a1e64@digitalocean.com
> virtio_net: can change MTU after installing program
Maybe not for virtio_net, but that same thing doesn't work on mlx5:
$ sudo ip link set dev ens1f1 mtu 8192
RTNETLINK answers: Invalid argument
-Toke
next prev parent reply other threads:[~2020-02-26 9:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 0:57 [PATCH RFC net-next] virtio_net: Relax queue requirement for using XDP David Ahern
2020-02-26 1:37 ` Jakub Kicinski
2020-02-26 3:00 ` Jason Wang
2020-02-26 3:24 ` David Ahern
2020-02-26 3:29 ` Jason Wang
2020-02-26 3:34 ` David Ahern
2020-02-26 3:52 ` Jason Wang
2020-02-26 4:35 ` David Ahern
2020-02-26 5:51 ` Jason Wang
2020-02-26 8:19 ` Toke Høiland-Jørgensen
2020-02-26 8:23 ` Michael S. Tsirkin
2020-02-26 8:34 ` Toke Høiland-Jørgensen
2020-02-26 8:42 ` Michael S. Tsirkin
2020-02-26 9:02 ` Toke Høiland-Jørgensen [this message]
2020-02-26 9:32 ` Michael S. Tsirkin
2020-02-26 15:58 ` David Ahern
2020-02-26 16:21 ` Toke Høiland-Jørgensen
2020-02-26 17:08 ` Michael S. Tsirkin
2020-02-26 21:31 ` Toke Høiland-Jørgensen
2020-02-27 3:27 ` David Ahern
2020-02-27 10:19 ` Toke Høiland-Jørgensen
2020-02-27 10:41 ` Magnus Karlsson
2020-09-28 3:13 ` David Ahern
2020-09-28 14:25 ` Magnus Karlsson
2020-09-29 2:44 ` David Ahern
2020-02-26 6:48 ` Michael S. Tsirkin
2020-02-26 7:28 ` Jason Wang
2020-02-26 8:21 ` Michael S. Tsirkin
2020-02-26 6:43 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8tlzppw.fsf@toke.dk \
--to=toke@redhat.com \
--cc=dahern@digitalocean.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).