From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3100C43381 for ; Fri, 1 Mar 2019 15:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 976A320850 for ; Fri, 1 Mar 2019 15:56:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388912AbfCAP45 (ORCPT ); Fri, 1 Mar 2019 10:56:57 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:39470 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387833AbfCAP45 (ORCPT ); Fri, 1 Mar 2019 10:56:57 -0500 Received: by mail-ed1-f66.google.com with SMTP id p27so20412855edc.6 for ; Fri, 01 Mar 2019 07:56:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=17vHoBbQ4DiDbn0fk3FEzuXPodB1iG2ttejWAZe3eic=; b=T41y3OE0JPafN4gezWVjNJtnNv6Z4dIh1vqRPFEWOxrcDCHq4w1D2odNu59lJZL7oA UUn5akCdqhHaP8ifAV+QODldm2o1nyVHnLWshbVOk/k0DpFJpy27exTg1/3xGFySbgGL AnpBGtJ/VLvT4IPQd1IVP3GJeAqLfTbdJSvti8efKZOTwWUQCbfRV/CcIY1lR6tptL7N JJP57URngvkb3D9y+6wwnTD50cA5bIkrwAG8tjcMATW4Nwp+eEH9TAYUgemyZvMTk21L xcymCeoXHqhWfmrJ9ieHe0WmNcjCm8ARzDCbYlImm57KKzd0Az/ey6T/r+qDFkUi4r3u qw8w== X-Gm-Message-State: APjAAAXgTZOsydIwoTwqcSZB65ufdtpQOk6bDrTHFqxz8hr/A00RjONH +Ptusziz/VonVq5VwlBRf6GVgg== X-Google-Smtp-Source: APXvYqxDSvRR1fJttb/lpi3ukb9BUCxpoikoICexnD+lntHM4B/t5HOGK3azd4jy3bp/s464yAsToQ== X-Received: by 2002:a17:906:1dd7:: with SMTP id v23mr3479261ejh.164.1551455815535; Fri, 01 Mar 2019 07:56:55 -0800 (PST) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id g11sm6197603edf.44.2019.03.01.07.56.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Mar 2019 07:56:54 -0800 (PST) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 3907E183BB9; Fri, 1 Mar 2019 16:56:54 +0100 (CET) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Ioana Ciornei , "netdev\@vger.kernel.org" , "davem\@davemloft.net" Cc: Ioana Ciocoi Radulescu , "brouer\@redhat.com" , "ilias.apalodimas\@linaro.org" , Ioana Ciornei Subject: Re: [PATCH 2/2] dpaa2-eth: add XDP_REDIRECT support In-Reply-To: <1551455248-26405-3-git-send-email-ioana.ciornei@nxp.com> References: <1551455248-26405-1-git-send-email-ioana.ciornei@nxp.com> <1551455248-26405-3-git-send-email-ioana.ciornei@nxp.com> X-Clacks-Overhead: GNU Terry Pratchett Date: Fri, 01 Mar 2019 16:56:54 +0100 Message-ID: <87o96ulha1.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Ioana Ciornei writes: > From: Ioana Radulescu > > Implement support for the XDP_REDIRECT action. > > The redirected frame is transmitted and confirmed on the regular Tx/Tx > conf queues. Frame is marked with the "XDP" type in the software > annotation, since it requires special treatment. > > We don't have good hardware support for TX batching, so the > XDP_XMIT_FLUSH flag doesn't make a difference for now; ndo_xdp_xmit > performs the actual Tx operation on the spot. > > Signed-off-by: Ioana Ciornei > Signed-off-by: Ioana Radulescu > --- > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 171 +++++++++++++++++++-- > drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h | 13 ++ > .../net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 1 + > 3 files changed, 170 insertions(+), 15 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > index 3acfd8c..fbd2f82 100644 > --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c > @@ -296,6 +296,7 @@ static u32 run_xdp(struct dpaa2_eth_priv *priv, > xdp.data_end = xdp.data + dpaa2_fd_get_len(fd); > xdp.data_hard_start = xdp.data - XDP_PACKET_HEADROOM; > xdp_set_data_meta_invalid(&xdp); > + xdp.rxq = &ch->xdp_rxq; > > xdp_act = bpf_prog_run_xdp(xdp_prog, &xdp); > > @@ -328,6 +329,17 @@ static u32 run_xdp(struct dpaa2_eth_priv *priv, > xdp_release_buf(priv, ch, addr); > ch->stats.xdp_drop++; > break; > + case XDP_REDIRECT: > + dma_unmap_page(priv->net_dev->dev.parent, addr, > + DPAA2_ETH_RX_BUF_SIZE, DMA_BIDIRECTIONAL); > + ch->buf_count--; > + xdp.data_hard_start = vaddr; > + err = xdp_do_redirect(priv->net_dev, &xdp, xdp_prog); > + if (unlikely(err)) > + ch->stats.xdp_drop++; > + else > + ch->stats.xdp_redirect++; > + break; > } You're missing a call to xdp_do_flush_map() somewhere; things are not going to work properly without it. From a quick perusal of dpaa2-eth.c I would guess it should be somewhere near the end of dpaa2_eth_poll()... -Toke