From: ebiederm@xmission.com (Eric W. Biederman)
To: Dmitry Vyukov <dvyukov@google.com>
Cc: David Miller <davem@davemloft.net>,
nicolas.dichtel@6wind.com, Al Viro <viro@zeniv.linux.org.uk>,
Thomas Graf <tgraf@suug.ch>,
xiyou.wangcong@gmail.com, netdev@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
jmorris@namei.org, yoshfuji@linux-ipv6.org,
Patrick McHardy <kaber@trash.net>,
syzkaller <syzkaller@googlegroups.com>,
Kostya Serebryany <kcc@google.com>,
Alexander Potapenko <glider@google.com>,
Eric Dumazet <edumazet@google.com>,
Kees Cook <keescook@google.com>, Julien Tinnes <jln@google.com>,
Sasha Levin <sasha.levin@oracle.com>
Subject: Re: Resource leak in unshare
Date: Mon, 02 Nov 2015 13:01:41 -0600 [thread overview]
Message-ID: <87oafcrzsa.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <CACT4Y+Y5mcBrnLOsXchJVrO_8FD-u=EFU67WsH3bU51aAU-idA@mail.gmail.com> (Dmitry Vyukov's message of "Mon, 2 Nov 2015 12:05:09 +0100")
Dmitry Vyukov <dvyukov@google.com> writes:
> Hello,
>
> I am hitting the following warnings on
> bcee19f424a0d8c26ecf2607b73c690802658b29 (4.3):
Do you have any trace of the earlier failures?
This appears to be something caused by an earlier failure (possibly
whatever fails to allocate memory). Having network devices present
but being in the generic cleanup routines is wrong.
If there is no additional information can you please rerun with the
following change applied? That should at least report which function is
failing, and give us a good clue where to start debugging this.
Eric
----
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 2c2eb1b629b1..125c94af22b8 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -292,6 +292,7 @@ out:
return error;
out_undo:
+ WARN(1, "net ops->init %pF returned with %d\n", ops->init, error);
/* Walk through the list backwards calling the exit functions
* for the pernet modules whose init functions did not fail.
*/
next prev parent reply other threads:[~2015-11-02 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 11:05 Resource leak in unshare Dmitry Vyukov
2015-11-02 19:01 ` Eric W. Biederman [this message]
2015-11-02 19:54 ` Eric Dumazet
2015-11-03 0:03 ` Eric Dumazet
2015-11-03 1:08 ` Eric Dumazet
2015-11-03 1:16 ` Eric Dumazet
2015-11-03 3:55 ` David Miller
2015-11-03 8:48 ` Dmitry Vyukov
2015-11-03 12:48 ` Eric Dumazet
2015-11-03 15:21 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oafcrzsa.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=jln@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kcc@google.com \
--cc=keescook@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=tgraf@suug.ch \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).