From: "Zhao\, Gang" <gamerh2o@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Jes.Sorensen@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH 02/13] staging: r8188eu: Remove pointless "alignment" entry in recv_frame
Date: Sun, 16 Feb 2014 11:02:52 +0800 [thread overview]
Message-ID: <87ob27bvz7.fsf@will.lan> (raw)
In-Reply-To: <1392418457-3203-3-git-send-email-Larry.Finger@lwfinger.net> (Larry Finger's message of "Fri, 14 Feb 2014 16:54:06 -0600")
On Sat, 2014-02-15 at 06:54:06 +0800, Larry Finger wrote:
> This alignment entry in union recv_frame does nothing. It certainly
> dues not ensure alignment.
^
typo here.
I accidently sent this as a private mail before, better to resend to
the list.
>
> Suggested-by: Jes.Sorensen@redhat.com
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Jes.Sorensen@redhat.com
> ---
> drivers/staging/rtl8188eu/include/rtw_recv.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h b/drivers/staging/rtl8188eu/include/rtw_recv.h
> index 866c9e4..c6d7a65 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_recv.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_recv.h
> @@ -292,7 +292,6 @@ struct recv_frame_hdr {
> union recv_frame {
> union {
> struct recv_frame_hdr hdr;
> - uint mem[RECVFRAME_HDR_ALIGN>>2];
> } u;
> };
next prev parent reply other threads:[~2014-02-16 3:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 22:54 [PATCH 00/13] Cleanups for r8188eu Larry Finger
2014-02-14 22:54 ` [PATCH 01/13] staging: r8188eu: Remove unnecessary list_head entry from recv_frame union Larry Finger
2014-02-14 22:54 ` [PATCH 02/13] staging: r8188eu: Remove pointless "alignment" entry in recv_frame Larry Finger
2014-02-16 3:02 ` Zhao, Gang [this message]
2014-02-16 9:09 ` Dan Carpenter
2014-02-16 16:26 ` Larry Finger
2014-02-14 22:54 ` [PATCH 03/13] staging: r8188eu: Remove union wrapping of recv_frame Larry Finger
2014-02-14 22:54 ` [PATCH 04/13] staging: r8188eu: Remove pkt_to_recv{frame, data, mem} routines Larry Finger
2014-02-14 22:54 ` [PATCH 05/13] staging: r8188eu: Remove unused get_rxbuf_desc() Larry Finger
2014-02-14 22:54 ` [PATCH 06/13] staging: r8188eu: Remove get_recvframe_len() Larry Finger
2014-02-14 22:54 ` [PATCH 07/13] staging: r8188eu: Remove get_recvframe_data() Larry Finger
2014-02-14 22:54 ` [PATCH 08/13] staging: r8188eu: Remove unused union Larry Finger
2014-02-14 22:54 ` [PATCH 09/13] staging: r8188eu: Remove wrapper _exit_critical_mutex() Larry Finger
2014-02-14 22:54 ` [PATCH 10/13] staging: r8188eu: Remove wrapper _enter_critical_mutex() Larry Finger
2014-02-15 10:41 ` Dan Carpenter
2014-02-15 17:23 ` Larry Finger
2014-02-15 20:38 ` Greg KH
2014-02-15 20:41 ` Greg KH
2014-02-17 5:35 ` Larry Finger
2014-02-14 22:54 ` [PATCH 11/13] staging: r8188eu: Remove wrapper routine _init_workitem() Larry Finger
2014-02-14 22:54 ` [PATCH 12/13] staging: r8188eu: Remove wrapper routine _set_workitem() Larry Finger
2014-02-14 22:54 ` [PATCH 13/13] staging: r8188eu: Make firmware buffer persistent Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob27bvz7.fsf@will.lan \
--to=gamerh2o@gmail.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).