netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cdc_ether: add usb id for Ericsson F3507g
@ 2009-02-25 14:33 Bjørn Mork
  2009-03-02  4:44 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Bjørn Mork @ 2009-02-25 14:33 UTC (permalink / raw)
  To: netdev

The Ericsson F3507g wireless broadband module provides a CDC Ethernet
compliant interface, but identifies it as a "Mobile Direct Line" CDC
subclass, thereby preventing the CDC Ethernet class driver from picking
it up.  This patch adds the device id to cdc_ether.c as a workaround.

Ericsson has provided a "class" driver for this device:
http://kerneltrap.org/mailarchive/linux-net/2008/10/28/3832094
But closer inspection of that driver reveals that it adds little more
than duplication of code from cdc_ether.c.  See also
http://marc.info/?l=linux-usb&m=123334979706403&w=2


Signed-off-by: Bjørn Mork <bjorn@mork.no>

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 0e061df..55e8ecc 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -559,6 +559,11 @@ static const struct usb_device_id	products [] = {
 	USB_INTERFACE_INFO(USB_CLASS_COMM, USB_CDC_SUBCLASS_ETHERNET,
 			USB_CDC_PROTO_NONE),
 	.driver_info = (unsigned long) &cdc_info,
+}, {
+	/* Ericsson F3507g */
+	USB_DEVICE_AND_INTERFACE_INFO(0x0bdb, 0x1900, USB_CLASS_COMM,
+			USB_CDC_SUBCLASS_MDLM, USB_CDC_PROTO_NONE),
+	.driver_info = (unsigned long) &cdc_info,
 },
 	{ },		// END
 };



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] cdc_ether: add usb id for Ericsson F3507g
  2009-02-25 14:33 [PATCH] cdc_ether: add usb id for Ericsson F3507g Bjørn Mork
@ 2009-03-02  4:44 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-03-02  4:44 UTC (permalink / raw)
  To: bjorn; +Cc: netdev

From: Bjørn Mork <bjorn@mork.no>
Date: Wed, 25 Feb 2009 15:33:58 +0100

> The Ericsson F3507g wireless broadband module provides a CDC Ethernet
> compliant interface, but identifies it as a "Mobile Direct Line" CDC
> subclass, thereby preventing the CDC Ethernet class driver from picking
> it up.  This patch adds the device id to cdc_ether.c as a workaround.
> 
> Ericsson has provided a "class" driver for this device:
> http://kerneltrap.org/mailarchive/linux-net/2008/10/28/3832094
> But closer inspection of that driver reveals that it adds little more
> than duplication of code from cdc_ether.c.  See also
> http://marc.info/?l=linux-usb&m=123334979706403&w=2
> 
> Signed-off-by: Bjørn Mork <bjorn@mork.no>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-03-02  4:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-25 14:33 [PATCH] cdc_ether: add usb id for Ericsson F3507g Bjørn Mork
2009-03-02  4:44 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).