From: Jakub Sitnicki <jakub@cloudflare.com>
To: phx <phx0fer@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
John Fastabend <john.fastabend@gmail.com>,
Jiayuan Chen <jiayuan.chen@linux.dev>,
Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf v2] bpf, sockmap: annotate the psock teardown data races
Date: Tue, 27 Oct 2026 17:33:15 +0100 [thread overview]
Message-ID: <87pkwv5cj8.fsf@cloudflare.com> (raw)
In-Reply-To: <CAKvCo-zf6=ABrMEn_8r7rJFFvaaXQrz8GAUQ9Uz4h0Ze9gY68w@mail.gmail.com> (phx's message of "Tue, 27 Oct 2026 13:10:52 +0800")
On Tue, Oct 27, 2026 at 01:10 PM +08, phx wrote:
> Sorry for the long silence — my laptop died right after v2 and took the
> local mail and the working tree with it. Agreed that the ordering fix is
> the right one; please go ahead with the commandeer, Jakub.
>
> I do still have the reproducer (a KCSAN selftest for this race, verified
> in QEMU). Say the word and I will post it, or send it to you to fold into
> your respin.
Feel free to iterate on the patch once you get your dev env restored.
We would also need selftest coverage for the race, if it reproduces
relatively fast. You can take a look at test_race_insert_listen for an
example.
next prev parent reply other threads:[~2026-10-27 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 15:56 [PATCH bpf] bpf, sockmap: use READ_ONCE/WRITE_ONCE for saved_data_ready in the verdict path Dudu Lu
2026-10-21 16:37 ` bot+bpf-ci
2026-10-21 16:45 ` Alexei Starovoitov
2026-10-21 20:30 ` Jakub Sitnicki
2026-10-22 5:48 ` [PATCH bpf v2] bpf, sockmap: annotate the psock teardown data races Dudu Lu
2026-10-22 15:40 ` Alexei Starovoitov
2026-10-23 18:49 ` Jakub Sitnicki
2026-10-23 18:53 ` Alexei Starovoitov
2026-10-26 12:33 ` Jakub Sitnicki
2026-10-27 5:10 ` phx
2026-10-27 16:33 ` Jakub Sitnicki [this message]
2026-10-27 16:46 ` Alexei Starovoitov
2026-10-27 17:34 ` Jakub Sitnicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkwv5cj8.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phx0fer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox