Re: [RFCv5 05/13] net: usb: use accessor helper for usbnet private data

["Bjørn Mork" <bjorn@mork.no>]

Oliver Neukum <oneukum@suse.com> writes:
> On 09.03.26 18:46, Bjørn Mork wrote:
>> Oliver Neukum <oneukum@suse.com> writes:
>> 
>>> diff --git a/drivers/net/usb/cdc_mbim.c b/drivers/net/usb/cdc_mbim.c
>>> index dbf01210b0e7..5522dc137d45 100644
>>> --- a/drivers/net/usb/cdc_mbim.c
>>> +++ b/drivers/net/usb/cdc_mbim.c
>>> @@ -43,7 +43,7 @@ enum cdc_mbim_flags {
>>>   /* using a counter to merge subdriver requests with our own into a combined state */
>>>   static int cdc_mbim_manage_power(struct usbnet *dev, int on)
>>>   {
>>> -	struct cdc_mbim_state *info = (void *)&dev->data;
>>> +	struct cdc_mbim_state *info = usbnet_priv(dev);
>>>   	int rv = 0;
>>>     	dev_dbg(&dev->intf->dev, "%s() pmcount=%d, on=%d\n", __func__,
>>> atomic_read(&info->pmcount), on);
>> I'm not sure I'm following all the conversions, but you are aware
>> that
>> cdc_mbim and cdc_ncm share a few functions struct cdc_ncm_ctx state, the
>> and therefore have to cooperate wrt the private data layout?
>
> Hi,
>
> I was not aware of that. What do you think about the approach taken
> in the attachment? It just makes sure that the first part of the
> descriptors match.

Looks reasonable to me.  I haven't actually tested it, though.


Bjørn