From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Jesper Dangaard Brouer <hawk@kernel.org>,
netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
bpf@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
horms@kernel.org, jiri@resnulli.us, edumazet@google.com,
xiyou.wangcong@gmail.com, jhs@mojatatu.com, atenart@redhat.com,
carges@cloudflare.com, kernel-team@cloudflare.com
Subject: Re: [PATCH net-next v3 6/6] net: sched: sch_dualpi2: use qdisc_dequeue_drop() for dequeue drops
Date: Tue, 10 Feb 2026 13:00:53 +0100 [thread overview]
Message-ID: <87pl6cyfii.fsf@toke.dk> (raw)
In-Reply-To: <177039509565.2258217.3624858167198291525.stgit@firesoul>
Jesper Dangaard Brouer <hawk@kernel.org> writes:
> DualPI2 drops packets during dequeue but was using kfree_skb_reason()
> directly, bypassing trace_qdisc_drop. Convert to qdisc_dequeue_drop()
> and add QDISC_DROP_L4S_STEP_NON_ECN to the qdisc drop reason enum.
>
> - Set TCQ_F_DEQUEUE_DROPS flag in dualpi2_init()
> - Use enum qdisc_drop_reason in drop_and_retry()
> - Replace kfree_skb_reason() with qdisc_dequeue_drop()
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202602061240.CRDtcOeX-lkp@intel.com/
> Signed-off-by: Jesper Dangaard Brouer <hawk@kernel.org>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
prev parent reply other threads:[~2026-02-10 12:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 16:24 [PATCH net-next v3 0/6] net: sched: refactor qdisc drop reasons into dedicated tracepoint Jesper Dangaard Brouer
2026-02-06 16:24 ` [PATCH net-next v3 1/6] net: sched: introduce qdisc-specific drop reason tracing Jesper Dangaard Brouer
2026-02-10 11:47 ` Toke Høiland-Jørgensen
2026-02-11 8:36 ` Paolo Abeni
2026-02-11 8:46 ` Paolo Abeni
2026-02-13 17:50 ` Jesper Dangaard Brouer
2026-02-11 8:50 ` Paolo Abeni
2026-02-06 16:24 ` [PATCH net-next v3 2/6] net: sched: sfq: convert to qdisc drop reasons Jesper Dangaard Brouer
2026-02-10 11:48 ` Toke Høiland-Jørgensen
2026-02-06 16:24 ` [PATCH net-next v3 3/6] net: sched: sch_cake: use enum qdisc_drop_reason for cobalt_should_drop Jesper Dangaard Brouer
2026-02-10 11:52 ` Toke Høiland-Jørgensen
2026-02-06 16:24 ` [PATCH net-next v3 4/6] net: sched: rename QDISC_DROP_CAKE_FLOOD to QDISC_DROP_FLOOD_PROTECTION Jesper Dangaard Brouer
2026-02-10 11:53 ` Toke Høiland-Jørgensen
2026-02-06 16:24 ` [PATCH net-next v3 5/6] net: sched: rename QDISC_DROP_FQ_* to generic names Jesper Dangaard Brouer
2026-02-10 11:54 ` Toke Høiland-Jørgensen
2026-02-06 16:24 ` [PATCH net-next v3 6/6] net: sched: sch_dualpi2: use qdisc_dequeue_drop() for dequeue drops Jesper Dangaard Brouer
2026-02-10 12:00 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pl6cyfii.fsf@toke.dk \
--to=toke@redhat.com \
--cc=atenart@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=carges@cloudflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox