From: Petr Machata <petrm@nvidia.com>
To: "François Michel" <francois.michel@uclouvain.be>
Cc: Petr Machata <petrm@nvidia.com>, <netdev@vger.kernel.org>,
<stephen@networkplumber.org>
Subject: Re: [PATCH v2 iproute2-next 1/2] tc: support the netem seed parameter for loss and corruption events
Date: Wed, 30 Aug 2023 15:22:41 +0200 [thread overview]
Message-ID: <87pm34slyw.fsf@nvidia.com> (raw)
In-Reply-To: <172898f6-56a7-6ce3-212c-a468f4ad6262@uclouvain.be>
François Michel <francois.michel@uclouvain.be> writes:
> Hi,
>
> Le 29/08/23 à 12:07, Petr Machata a écrit :
>> Took me a while to fight my way through all the unreads to this, and
>> it's already merged, but...
>> francois.michel@uclouvain.be writes:
>>
>>> diff --git a/tc/q_netem.c b/tc/q_netem.c
>>> index 8ace2b61..febddd49 100644
>>> --- a/tc/q_netem.c
>>> +++ b/tc/q_netem.c
>>> @@ -31,6 +31,7 @@ static void explain(void)
>>> " [ loss random PERCENT [CORRELATION]]\n"
>>> " [ loss state P13 [P31 [P32 [P23 P14]]]\n"
>>> " [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
>>> + " [ seed SEED \n]"
>> The newline seems misplaced.
>
> Sorry for that, I don't know how I could have missed that.
> Should I send a patch to fix this ?
That would be the way to get it fixed, yes.
next prev parent reply other threads:[~2023-08-30 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 10:01 [PATCH v2 iproute2-next 0/2] tc: support the netem seed parameter for loss and corruption events francois.michel
2023-08-23 10:01 ` [PATCH v2 iproute2-next 1/2] " francois.michel
2023-08-29 10:07 ` Petr Machata
2023-08-30 12:30 ` François Michel
2023-08-30 13:22 ` Petr Machata [this message]
2023-08-30 15:01 ` David Ahern
2023-08-23 10:01 ` [PATCH v2 iproute2-next 2/2] man: tc-netem: add section for specifying the netem seed francois.michel
2023-08-23 13:16 ` [PATCH v2 iproute2-next 0/2] tc: support the netem seed parameter for loss and corruption events Stephen Hemminger
2023-08-29 3:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm34slyw.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=francois.michel@uclouvain.be \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).