From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35E7B134B6 for ; Wed, 2 Aug 2023 23:30:01 +0000 (UTC) Received: from mgamail.intel.com (unknown [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A686B26A2; Wed, 2 Aug 2023 16:29:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691018998; x=1722554998; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=h99e192bzCZMzg/eEGhvy+QImTiT2HSo8oaY9XUpOy4=; b=gLYydFd3v5JaFCp+cFMHGQbkRNePcOjRxqzfrWl+WuZiZ+e7kOmiMugk nJdBrBWCv2sy3vSr2jwxEY2tIIJhaT3400moJYEgEIeM5YmHVY33P5+28 jc1w96+lj3e4xB1XYfcfTfhuu/FuhWm644MMOiI5StVsyiXys3NRu2sDy TUn3hsvuVODRasVRTDbw+YXHbhCpTr/2h7/uDbiPG1MkZVK8Cg6ytzOkV 8ZfQB7IfTQQXsjyqqACEdwyuii2YFnVWrFuaxeZNbAs8oTvkX7+D77rVx W1+Kg/PJ1lL9elWx/JQsFFAn7MzAwWLdpMckagJushs/UROgD7vIosDS8 A==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="369727663" X-IronPort-AV: E=Sophos;i="6.01,250,1684825200"; d="scan'208";a="369727663" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 16:29:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="819405156" X-IronPort-AV: E=Sophos;i="6.01,250,1684825200"; d="scan'208";a="819405156" Received: from rbappers-mobl2.amr.corp.intel.com (HELO vcostago-mobl3) ([10.209.84.112]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 16:29:56 -0700 From: Vinicius Costa Gomes To: Vladimir Oltean , netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Cong Wang , Jiri Pirko , linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Muhammad Husaini Zulkifli , Peilin Ye , Pedro Tammela , Richard Cochran , Zhengchao Shao , Maxim Georgiev Subject: Re: [PATCH v3 net-next 09/10] selftests/tc-testing: test that taprio can only be attached as root In-Reply-To: <20230801182421.1997560-10-vladimir.oltean@nxp.com> References: <20230801182421.1997560-1-vladimir.oltean@nxp.com> <20230801182421.1997560-10-vladimir.oltean@nxp.com> Date: Wed, 02 Aug 2023 16:29:55 -0700 Message-ID: <87pm4510r0.fsf@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Vladimir Oltean writes: > Check that the "Can only be attached as root qdisc" error message from > taprio is effective by attempting to attach it to a class of another > taprio qdisc. That operation should fail. > > In the bug that was squashed by change "net/sched: taprio: try again to > report q->qdiscs[] to qdisc_leaf()", grafting a child taprio to a root > software taprio would be misinterpreted as a change() to the root > taprio. Catch this by looking at whether the base-time of the root > taprio has changed to follow the base-time of the child taprio, > something which should have absolutely never happened assuming correct > semantics. > This test is somehow flaky (all others are fine), 1 in ~4 times, it fails. Taking a look at the test I couldn't quickly find out the reason for the flakyness. Here's the verbose output of one of the failures: vcgomes@otc-cfl-clr-30 ~/src/net-next/tools/testing/selftests/tc-testing $ sudo ./tdc.py -e 39b4 -v -- ns/SubPlugin.__init__ ns/SubPlugin.adjust_command adjust_command: return command [/sbin/ip link add v0p0 type veth peer name v0p1] _exec_cmd: command "/sbin/ip link add v0p0 type veth peer name v0p1" ns/SubPlugin.adjust_command adjust_command: return command [/sbin/ip link set v0p0 up] _exec_cmd: command "/sbin/ip link set v0p0 up" ns/SubPlugin.adjust_command adjust_command: return command [/sbin/ip netns add tcut] _exec_cmd: command "/sbin/ip netns add tcut" ns/SubPlugin.adjust_command adjust_command: return command [/sbin/ip link set v0p1 netns tcut] _exec_cmd: command "/sbin/ip link set v0p1 netns tcut" ns/SubPlugin.adjust_command adjust_command: return command [/sbin/ip -n tcut link set v0p1 up] _exec_cmd: command "/sbin/ip -n tcut link set v0p1 up" ==================== =====> Test 39b4: Reject grafting taprio as child qdisc of software taprio -----> prepare stage ns/SubPlugin.adjust_command adjust_command: stage is setup; inserting netns stuff in command [echo "1 1 8" > /sys/bus/netdevsim/new_device] list [['echo', '"1', '1', '8"', '>', '/sys/bus/netdevsim/new_device']] adjust_command: return command [/sbin/ip netns exec tcut echo "1 1 8" > /sys/bus/netdevsim/new_device] command "/sbin/ip netns exec tcut echo "1 1 8" > /sys/bus/netdevsim/new_device" ns/SubPlugin.adjust_command adjust_command: stage is setup; inserting netns stuff in command [/sbin/tc qdisc replace dev eth0 handle 8001: parent root stab overhead 24 taprio num_tc 8 map 0 1 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 0 sched-entry S ff 20000000 clockid CLOCK_TAI] list [['/sbin/tc', 'qdisc', 'replace', 'dev', 'eth0', 'handle', '8001:', 'parent', 'root', 'stab', 'overhead', '24', 'taprio', 'num_tc', '8', 'map', '0', '1', '2', '3', '4', '5', '6', '7', 'queues', '1@0', '1@1', '1@2', '1@3', '1@4', '1@5', '1@6', '1@7', 'base-time', '0', 'sched-entry', 'S', 'ff', '20000000', 'clockid', 'CLOCK_TAI']] adjust_command: return command [/sbin/ip netns exec tcut /sbin/tc qdisc replace dev eth0 handle 8001: parent root stab overhead 24 taprio num_tc 8 map 0 1 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 0 sched-entry S ff 20000000 clockid CLOCK_TAI] command "/sbin/ip netns exec tcut /sbin/tc qdisc replace dev eth0 handle 8001: parent root stab overhead 24 taprio num_tc 8 map 0 1 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 0 sched-entry S ff 20000000 clockid CLOCK_TAI" -----> execute stage ns/SubPlugin.adjust_command adjust_command: stage is execute; inserting netns stuff in command [/sbin/tc qdisc replace dev eth0 parent 8001:7 taprio num_tc 8 map 0 1 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 200 sched-entry S ff 20000000 clockid CLOCK_TAI] list [['/sbin/tc', 'qdisc', 'replace', 'dev', 'eth0', 'parent', '8001:7', 'taprio', 'num_tc', '8', 'map', '0', '1', '2', '3', '4', '5', '6', '7', 'queues', '1@0', '1@1', '1@2', '1@3', '1@4', '1@5', '1@6', '1@7', 'base-time', '200', 'sched-entry', 'S', 'ff', '20000000', 'clockid', 'CLOCK_TAI']] adjust_command: return command [/sbin/ip netns exec tcut /sbin/tc qdisc replace dev eth0 parent 8001:7 taprio num_tc 8 map 0 1 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 200 sched-entry S ff 20000000 clockid CLOCK_TAI] command "/sbin/ip netns exec tcut /sbin/tc qdisc replace dev eth0 parent 8001:7 taprio num_tc 8 map 0 1 2 3 4 5 6 7 queues 1@0 1@1 1@2 1@3 1@4 1@5 1@6 1@7 base-time 200 sched-entry S ff 20000000 clockid CLOCK_TAI" -----> verify stage ns/SubPlugin.adjust_command adjust_command: stage is verify; inserting netns stuff in command [/sbin/tc -j qdisc show dev eth0 root | jq '.[].options.base_time'] list [['/sbin/tc', '-j', 'qdisc', 'show', 'dev', 'eth0', 'root', '|', 'jq', "'.[].options.base_time'"]] adjust_command: return command [/sbin/ip netns exec tcut /sbin/tc -j qdisc show dev eth0 root | jq '.[].options.base_time'] command "/sbin/ip netns exec tcut /sbin/tc -j qdisc show dev eth0 root | jq '.[].options.base_time'" -----> teardown stage ns/SubPlugin.adjust_command adjust_command: stage is teardown; inserting netns stuff in command [/sbin/tc qdisc del dev eth0 root] list [['/sbin/tc', 'qdisc', 'del', 'dev', 'eth0', 'root']] adjust_command: return command [/sbin/ip netns exec tcut /sbin/tc qdisc del dev eth0 root] command "/sbin/ip netns exec tcut /sbin/tc qdisc del dev eth0 root" ns/SubPlugin.adjust_command adjust_command: stage is teardown; inserting netns stuff in command [echo "1" > /sys/bus/netdevsim/del_device] list [['echo', '"1"', '>', '/sys/bus/netdevsim/del_device']] adjust_command: return command [/sbin/ip netns exec tcut echo "1" > /sys/bus/netdevsim/del_device] command "/sbin/ip netns exec tcut echo "1" > /sys/bus/netdevsim/del_device" ns/SubPlugin.post_suite ns/SubPlugin.adjust_command adjust_command: return command [/sbin/ip netns delete tcut] _exec_cmd: command "/sbin/ip netns delete tcut" All test results: 1..1 not ok 1 39b4 - Reject grafting taprio as child qdisc of software taprio Could not match regex pattern. Verify command output: parse error: Objects must consist of key:value pairs at line 1, column 334 Cheers, -- Vinicius