From: "Bjørn Mork" <bjorn@mork.no>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Daniel Golle <daniel@makrotopia.org>,
Alexander Couzens <lynxis@fe80.eu>
Subject: Re: [PATCH net 2/3] net: mediatek: sgmii: autonegotiation is required
Date: Fri, 20 Jan 2023 08:56:57 +0100 [thread overview]
Message-ID: <87pmb9vdti.fsf@miraculix.mork.no> (raw)
In-Reply-To: <Y8m75N5//L+PHo8f@shell.armlinux.org.uk> (Russell King's message of "Thu, 19 Jan 2023 21:53:40 +0000")
"Russell King (Oracle)" <linux@armlinux.org.uk> writes:
> If you have 'managed = "in-band-status";' in your DT, that will set
> "mode" to be MLO_AN_INBAND, and phylink_autoneg_inband(mode) will be
> true - which should result in the link being programmed for in-band
> mode. You should also find that mtk_pcs_get_state() gets called.
>
> Hmm, it looks like setting ss->pcs[i].pcs.poll to true was missed
> when support for inband was properly added, so that might be the
> issue there - as the mtk ethernet driver doesn't make use of
> phylink_mac_change().
OK, this doesn't just work as-is either. But I guess that's something
else. Will try to debug some more.
But I wonder: Why would I want to use "in-band-status" here? Is that
the preferred mode? Probably stupid question. But shouldn't we also
make this link work without it, whatever that takes?
Note that I don't have to care about unknown phys. No SFP cage on this
board.
Bjørn
next prev parent reply other threads:[~2023-01-20 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 17:12 [PATCH net 0/3] fixes for mtk_eth_soc Bjørn Mork
2023-01-19 17:12 ` [PATCH net 1/3] net: mediatek: sgmii: ensure the SGMII PHY is powered down on configuration Bjørn Mork
2023-01-19 17:17 ` Russell King (Oracle)
2023-01-19 19:03 ` Bjørn Mork
2023-01-19 17:12 ` [PATCH net 2/3] net: mediatek: sgmii: autonegotiation is required Bjørn Mork
2023-01-19 17:21 ` Russell King (Oracle)
2023-01-19 19:33 ` Bjørn Mork
2023-01-19 21:53 ` Russell King (Oracle)
2023-01-20 7:56 ` Bjørn Mork [this message]
2023-01-19 17:12 ` [PATCH net 3/3] net: mediatek: sgmii: fix duplex configuration Bjørn Mork
2023-01-19 17:14 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmb9vdti.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=Mark-MC.Lee@mediatek.com \
--cc=daniel@makrotopia.org \
--cc=john@phrozen.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).