netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	Jesper Dangaard Brouer <jbrouer@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Joanne Koong <joannelkoong@gmail.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Dave Marchevsky <davemarchevsky@fb.com>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Geliang Tang <geliang.tang@suse.com>,
	Jakub Sitnicki <jakub@cloudflare.com>,
	Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next] bpf: Add BPF-helper for accessing CLOCK_TAI
Date: Tue, 02 Aug 2022 09:06:44 +0200	[thread overview]
Message-ID: <87pmhj15vf.fsf@kurt> (raw)
In-Reply-To: <CAADnVQKqo1XfrPO8OYA1VpArKHZotuDjGNtxM0AftUj_R+vU7g@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 652 bytes --]

Hi Alexei,

On Tue Jun 07 2022, Alexei Starovoitov wrote:
> Anyway I guess new helper bpf_ktime_get_tai_ns() is ok, since
> it's so trivial, but selftest is necessary.

So, I did write a selftest [1] for testing bpf_ktime_get_tai_ns() and
verifying that the access to the clock works. It uses AF_XDP sockets and
timestamps the incoming packets. The timestamps are then validated in
user space.

Since AF_XDP related code is migrating from libbpf to libxdp, I'm
wondering if that sample fits into the kernel's selftests or not. What
kind of selftest are you looking for?

Thanks,
Kurt

[1] - https://github.com/shifty91/xdp-timestamping/tree/master/src

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  parent reply	other threads:[~2022-08-02  7:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06 10:37 [PATCH bpf-next] bpf: Add BPF-helper for accessing CLOCK_TAI Kurt Kanzenbach
2022-06-06 15:57 ` Alexei Starovoitov
2022-06-07  9:14   ` Thomas Gleixner
2022-06-07 19:35     ` Jesper Dangaard Brouer
2022-06-08  2:01       ` Alexei Starovoitov
2022-06-08  6:13         ` Kurt Kanzenbach
2022-08-02  7:06         ` Kurt Kanzenbach [this message]
2022-08-02 15:03           ` Alexei Starovoitov
2022-08-03  6:29             ` Kurt Kanzenbach
2022-08-03  9:28               ` Maciej Fijalkowski
2022-08-03 17:29                 ` Andrii Nakryiko
2022-08-03 17:28               ` Andrii Nakryiko
2022-08-04  6:40                 ` Kurt Kanzenbach
2022-08-09  0:28                   ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmhj15vf.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=daniel@iogearbox.net \
    --cc=davemarchevsky@fb.com \
    --cc=geliang.tang@suse.com \
    --cc=jakub@cloudflare.com \
    --cc=jbrouer@redhat.com \
    --cc=joannelkoong@gmail.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=tglx@linutronix.de \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).