From: Petr Machata <petrm@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Petr Machata <petrm@nvidia.com>, <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next 1/3] netdevsim: Introduce support for L3 offload xstats
Date: Fri, 11 Mar 2022 18:31:57 +0100 [thread overview]
Message-ID: <87pmms8k4y.fsf@nvidia.com> (raw)
In-Reply-To: <20220311080743.50447d96@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Jakub Kicinski <kuba@kernel.org> writes:
> On Fri, 11 Mar 2022 08:06:31 -0800 Jakub Kicinski wrote:
>> I'm okay with your version if you prefer, but the above works, right?
>> Or am I missing something?
I think it would. I mostly wanted to avoid comparing the pointers,
expressing this using an enum feels cleaner.
> Ah, you only have one fops now, I should have read the patch more
> carefully. Yup, that's also good.
Actually no, you do need one fops instance per file. But the fops
themselves point to the same functions each time, so I can have one
"generic" fops struct and just copy it to each instance.
next prev parent reply other threads:[~2022-03-11 17:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 16:12 [PATCH net-next 0/3] netdevsim: Support for L3 HW stats Petr Machata
2022-03-10 16:12 ` [PATCH net-next 1/3] netdevsim: Introduce support for L3 offload xstats Petr Machata
2022-03-11 5:13 ` Jakub Kicinski
2022-03-11 9:18 ` Petr Machata
2022-03-11 16:06 ` Jakub Kicinski
2022-03-11 16:07 ` Jakub Kicinski
2022-03-11 17:31 ` Petr Machata [this message]
2022-03-10 16:12 ` [PATCH net-next 2/3] selftests: netdevsim: hw_stats_l3: Add a new test Petr Machata
2022-03-10 16:12 ` [PATCH net-next 3/3] selftests: mlxsw: " Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmms8k4y.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).