From: Thomas Gleixner <tglx@linutronix.de>
To: syzbot <syzbot+ca740b95a16399ceb9a5@syzkaller.appspotmail.com>,
davem@davemloft.net, hchunhui@mail.ustc.edu.cn, hdanton@sina.com,
ja@ssi.bg, jmorris@namei.org, kuznet@ms2.inr.ac.ru,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
syzkaller-bugs@googlegroups.com, yoshfuji@linux-ipv6.org,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: WARNING in hrtimer_forward
Date: Mon, 28 Sep 2020 18:13:42 +0200 [thread overview]
Message-ID: <87pn65khft.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <0000000000007d5ec805b04c5fc8@google.com>
On Sun, Sep 27 2020 at 07:29, syzbot wrote:
> syzbot has bisected this issue to:
>
> commit 0e7bbcc104baaade4f64205e9706b7d43c46db7d
> Author: Julian Anastasov <ja@ssi.bg>
> Date: Wed Jul 27 06:56:50 2016 +0000
>
> neigh: allow admin to set NUD_STALE
>
> bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1661d187900000
> start commit: ba5f4cfe bpf: Add comment to document BTF type PTR_TO_BTF_..
> git tree: bpf-next
> final oops: https://syzkaller.appspot.com/x/report.txt?x=1561d187900000
> console output: https://syzkaller.appspot.com/x/log.txt?x=1161d187900000
> kernel config: https://syzkaller.appspot.com/x/.config?x=d44e1360b76d34dc
> dashboard link: https://syzkaller.appspot.com/bug?extid=ca740b95a16399ceb9a5
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1148fe4b900000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=12f5218d900000
>
> Reported-by: syzbot+ca740b95a16399ceb9a5@syzkaller.appspotmail.com
> Fixes: 0e7bbcc104ba ("neigh: allow admin to set NUD_STALE")
That bisect does not make any sense and reverting the commit on top of
next does not help either.
What happens is:
fail-16132 [029] .... 933.714866: sys_enter: NR 16 (3, 8b28, 20000000, 0, 0, 0)
<idle>-0 [001] d.s2 933.715768: hrtimer_cancel: hrtimer=00000000fe9fe1b9
<idle>-0 [001] ..s1 933.715771: hrtimer_expire_entry: hrtimer=00000000fe9fe1b9 function=mac80211_hwsim_beacon now=933716506319
fail-16132 [029] d..1 933.715794: hrtimer_start: hrtimer=00000000fe9fe1b9 function=mac80211_hwsim_beacon expires=933818720770 softexpires=933818720770 mode=REL|SOFT
<idle>-0 [001] ..s1 933.715812: hrtimer_forward: hrtimer=00000000fe9fe1b9
So the timer was armed at some point and then the expiry which does the
forward races with the ioctl which starts the timer. Lack of
serialization or such ...
Thanks,
tglx
next prev parent reply other threads:[~2020-09-28 16:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 8:48 WARNING in hrtimer_forward syzbot
2020-09-27 0:38 ` syzbot
2020-09-27 14:29 ` syzbot
2020-09-28 16:13 ` Thomas Gleixner [this message]
[not found] ` <20200928171137.16804-1-hdanton@sina.com>
2020-09-28 18:35 ` Thomas Gleixner
2020-09-30 7:26 ` Dmitry Vyukov
[not found] ` <20200927080452.18340-1-hdanton@sina.com>
2020-09-28 14:18 ` Thomas Gleixner
2021-11-03 9:21 ` [syzbot] " syzbot
2021-12-04 10:19 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn65khft.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=davem@davemloft.net \
--cc=hchunhui@mail.ustc.edu.cn \
--cc=hdanton@sina.com \
--cc=ja@ssi.bg \
--cc=jmorris@namei.org \
--cc=johannes.berg@intel.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+ca740b95a16399ceb9a5@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).