From: Petr Machata <petrm@mellanox.com>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Ido Schimmel <idosch@idosch.org>,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
jiri@mellanox.com, mlxsw@mellanox.com, michael.chan@broadcom.com,
saeedm@mellanox.com, leon@kernel.org, kadlec@netfilter.org,
fw@strlen.de, jhs@mojatatu.com, xiyou.wangcong@gmail.com,
simon.horman@netronome.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 01/13] net: sched: Pass qdisc reference in struct flow_block_offload
Date: Fri, 10 Jul 2020 20:01:51 +0200 [thread overview]
Message-ID: <87pn93fdv4.fsf@mellanox.com> (raw)
In-Reply-To: <20200710171327.GA15481@salvia>
Pablo Neira Ayuso <pablo@netfilter.org> writes:
> On Fri, Jul 10, 2020 at 06:22:03PM +0200, Petr Machata wrote:
>>
>> Pablo Neira Ayuso <pablo@netfilter.org> writes:
>>
>> > Moreover, the flow_offload infrastructure should also remain
>> > independent from the front-end, either tc/netfilter/ethtool, this is
>> > pulling in tc specific stuff into it, eg.
>>
>> Hmm, OK, so I should not have assumed there is always a qdisc associated
>> with a block.
>>
>> I'm not sure how strong your objection to pulling in TC is. Would it be
>> OK, instead of replacing the device with a qdisc in flow_block_indr, to
>> put in both? The qdisc can be NULL for the "normal" binder types,
>> because there the block is uniquely identified just by the type. For the
>> "non-normal" ones it would be obvious how to initialize it.
>
> Adding an extra field to flow_block_indr instead of replacing struct
> net_device should be ok for your new qevent use-case, right? This new
> Qdisc field will be NULL for the existing use-cases, that is what you
> mean, correct?
Yes, that is what I have in mind.
OK, I'll update the patches accordingly. Thanks!
> I still did not have a look at this new qevent infrastructure, so I
> don't have a better proposal right now.
next prev parent reply other threads:[~2020-07-10 18:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 13:56 [PATCH net-next 00/13] mlxsw: Add support for buffer drops mirroring Ido Schimmel
2020-07-10 13:56 ` [PATCH net-next 01/13] net: sched: Pass qdisc reference in struct flow_block_offload Ido Schimmel
2020-07-10 14:15 ` Pablo Neira Ayuso
2020-07-10 15:15 ` Petr Machata
2020-07-10 15:26 ` Pablo Neira Ayuso
2020-07-10 16:22 ` Petr Machata
2020-07-10 17:13 ` Pablo Neira Ayuso
2020-07-10 18:01 ` Petr Machata [this message]
2020-07-10 13:56 ` [PATCH net-next 02/13] mlxsw: reg: Add Monitoring Mirror Trigger Enable Register Ido Schimmel
2020-07-10 13:56 ` [PATCH net-next 03/13] mlxsw: reg: Add Monitoring Port Analyzer Global Register Ido Schimmel
2020-07-10 13:56 ` [PATCH net-next 04/13] mlxsw: spectrum_span: Move SPAN operations out of global file Ido Schimmel
2020-07-10 13:56 ` [PATCH net-next 05/13] mlxsw: spectrum_span: Prepare for global mirroring triggers Ido Schimmel
2020-07-10 13:56 ` [PATCH net-next 06/13] mlxsw: spectrum_span: Add support " Ido Schimmel
2020-07-10 13:57 ` [PATCH net-next 07/13] mlxsw: spectrum_span: Add APIs to enable / disable " Ido Schimmel
2020-07-10 13:57 ` [PATCH net-next 08/13] mlxsw: spectrum_flow: Convert a goto to a return Ido Schimmel
2020-07-10 13:57 ` [PATCH net-next 09/13] mlxsw: spectrum_flow: Drop an unused field Ido Schimmel
2020-07-10 13:57 ` [PATCH net-next 10/13] mlxsw: spectrum_matchall: Publish matchall data structures Ido Schimmel
2020-07-10 13:57 ` [PATCH net-next 11/13] mlxsw: spectrum_flow: Promote binder-type dispatch to spectrum.c Ido Schimmel
2020-07-10 13:57 ` [PATCH net-next 12/13] mlxsw: spectrum_qdisc: Offload mirroring on RED qevent early_drop Ido Schimmel
2020-07-10 13:57 ` [PATCH net-next 13/13] selftests: mlxsw: RED: Test offload of mirror on RED early_drop qevent Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn93fdv4.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=saeedm@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).