netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Machata <petrm@mellanox.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Amit Cohen <amitc@mellanox.com>, mlxsw <mlxsw@mellanox.com>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	"o.rempel\@pengutronix.de" <o.rempel@pengutronix.de>,
	Michal Kubecek <mkubecek@suse.cz>
Subject: Re: Link down reasons
Date: Fri, 29 May 2020 11:03:28 +0200	[thread overview]
Message-ID: <87pnant8nz.fsf@mellanox.com> (raw)
In-Reply-To: <20200528183703.GB849697@lunn.ch>


Andrew Lunn <andrew@lunn.ch> writes:

> It is called downshift. And we have support for it in the phylib core,
> if the PHY has the needed vendor register.
>
> https://elixir.bootlin.com/linux/v5.7-rc7/source/drivers/net/phy/phy-core.c#L341
> https://elixir.bootlin.com/linux/v5.7-rc7/source/drivers/net/phy/phy.c#L95

Thanks for the references.

> So in theory we could report:
>
> Link detected: yes (downshifted)
>
> Assuming your proposed API support a reason why it is up, not just a
> reason why it is down?

Michal Kubecek <mkubecek@suse.cz> writes:

> Perhaps we could use more general name than "link down reason", e.g.
> "extended state", and it could be reported even if the link is still up

All right, that makes sense to me. Let's make it extended state.

Thanks!

  reply	other threads:[~2020-05-29  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AM0PR0502MB38261D4F4F7A3BB5E0FDCD10D7B10@AM0PR0502MB3826.eurprd05.prod.outlook.com>
2020-05-27 21:38 ` Link down reasons Andrew Lunn
2020-05-28  5:56   ` Amit Cohen
2020-05-28  9:12     ` Petr Machata
2020-05-28 15:40       ` Andrew Lunn
2020-05-28 16:54         ` Petr Machata
2020-05-28 17:17           ` Michal Kubecek
2020-05-28 18:37           ` Andrew Lunn
2020-05-29  9:03             ` Petr Machata [this message]
2020-05-28  8:40 ` Oleksij Rempel
2020-05-28  9:22   ` Petr Machata
2020-05-28 10:28     ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnant8nz.fsf@mellanox.com \
    --to=petrm@mellanox.com \
    --cc=amitc@mellanox.com \
    --cc=andrew@lunn.ch \
    --cc=mkubecek@suse.cz \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).