From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
vladimir.oltean@nxp.com, po.liu@nxp.com
Subject: Re: [PATCH net v3 1/2] taprio: Fix enabling offload with wrong number of traffic classes
Date: Fri, 31 Jan 2020 10:00:54 -0800 [thread overview]
Message-ID: <87pnezbj55.fsf@linux.intel.com> (raw)
In-Reply-To: <20200131072453.454930eb@cakuba.hsd1.ca.comcast.net>
Jakub Kicinski <kuba@kernel.org> writes:
> On Wed, 29 Jan 2020 17:37:20 -0800, Vinicius Costa Gomes wrote:
>> If the driver implementing taprio offloading depends on the value of
>> the network device number of traffic classes (dev->num_tc) for
>> whatever reason, it was going to receive the value zero. The value was
>> only set after the offloading function is called.
>>
>> So, moving setting the number of traffic classes to before the
>> offloading function is called fixes this issue. This is safe because
>> this only happens when taprio is instantiated (we don't allow this
>> configuration to be changed without first removing taprio).
>>
>> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
>> Reported-by: Po Liu <po.liu@nxp.com>
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> Acked-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> What about Dave's question about resetting the tc state with
> netdev_reset_tc()?
I missed that question.
next prev parent reply other threads:[~2020-01-31 17:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 1:37 [PATCH net v3 0/2] taprio: Some fixes Vinicius Costa Gomes
2020-01-30 1:37 ` [PATCH net v3 1/2] taprio: Fix enabling offload with wrong number of traffic classes Vinicius Costa Gomes
2020-01-31 15:24 ` Jakub Kicinski
2020-01-31 18:00 ` Vinicius Costa Gomes [this message]
2020-01-30 1:37 ` [PATCH net v3 2/2] taprio: Fix still allowing changing the flags during runtime Vinicius Costa Gomes
2020-01-31 15:26 ` Jakub Kicinski
2020-01-31 17:59 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnezbj55.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=po.liu@nxp.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).