From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net v1] net: taprio: Fix returning EINVAL when configuring without flags
Date: Tue, 08 Oct 2019 17:22:13 -0700 [thread overview]
Message-ID: <87pnj66a4q.fsf@linux.intel.com> (raw)
In-Reply-To: <CA+h21hoc=shDEHSN-SEyO3qS7sBW4GzswcVrHW-7Sud9aP7apA@mail.gmail.com>
Hi,
Vladimir Oltean <olteanv@gmail.com> writes:
> Hi Vinicius,
>
> On Wed, 9 Oct 2019 at 02:19, Vinicius Costa Gomes
> <vinicius.gomes@intel.com> wrote:
>>
>> When configuring a taprio instance if "flags" is not specified (or
>> it's zero), taprio currently replies with an "Invalid argument" error.
>>
>> So, set the return value to zero after we are done with all the
>> checks.
>>
>> Fixes: 9c66d1564676 ("taprio: Add support for hardware offloading")
>> Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
>> ---
>
> You mean clockid, not flags, right?
I do mean "flags", yeah. The case I was testing was something like this:
$ tc qdisc replace dev $IFACE parent root handle 100 taprio \
num_tc 3 \
map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 \
queues 1@0 1@1 2@2 \
base-time $BASE_TIME \
sched-entry S 01 300000 \
sched-entry S 02 300000 \
sched-entry S 04 400000 \
clockid CLOCK_TAI
Cheers,
--
Vinicius
next prev parent reply other threads:[~2019-10-09 0:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 23:20 [PATCH net v1] net: taprio: Fix returning EINVAL when configuring without flags Vinicius Costa Gomes
2019-10-08 23:58 ` Vladimir Oltean
2019-10-09 0:11 ` Vladimir Oltean
2019-10-09 0:22 ` Vinicius Costa Gomes [this message]
2019-10-10 1:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnj66a4q.fsf@linux.intel.com \
--to=vinicius.gomes@intel.com \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).