From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH 0/4] sched: Fix qdisc interactions exposed by using sch_cake as a leaf qdisc Date: Wed, 09 Jan 2019 09:37:33 +0100 Message-ID: <87pnt6teeq.fsf@toke.dk> References: <20190107194733.31138-1-toke@toke.dk> <20190108.133053.2049686690825668341.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net To: David Miller Return-path: Received: from mail.toke.dk ([52.28.52.200]:41659 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729402AbfAIIhj (ORCPT ); Wed, 9 Jan 2019 03:37:39 -0500 In-Reply-To: <20190108.133053.2049686690825668341.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller writes: > From: Toke H=C3=B8iland-J=C3=B8rgensen > Date: Mon, 7 Jan 2019 20:47:29 +0100 > >> This series fixes a couple of issues exposed by running sch_cake as a >> leaf qdisc in an HFSC tree, which were discovered and reported by Pete >> Heist. The interaction between CAKE's GSO splitting and the parent >> qdisc's notion of its own queue length could cause queue stalls. While >> investigating the report, I also noticed that several qdiscs would >> dereference the skb pointer after dequeue, which is potentially >> problematic since the GSO splitting code also frees the original skb. >>=20 >> See the individual patches in the series for details. > > Toke, can you please resubmit this without patch #3. > > If you want to push for patch #3 still, it is much easier to submit > it separately. Can do :) -Toke