From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Smith Subject: Re: [PATCH 2/2] c/r: Add AF_INET support (v3) Date: Tue, 07 Jul 2009 18:31:32 -0700 Message-ID: <87prccq7t7.fsf@caffeine.danplanet.com> References: <1246994776-1882-1-git-send-email-danms@us.ibm.com> <1246994776-1882-3-git-send-email-danms@us.ibm.com> <4A53F50D.30001@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexey Dobriyan To: Brian Haley Return-path: In-Reply-To: <4A53F50D.30001-VXdhtT5mjnY@public.gmane.org> (Brian Haley's message of "Tue\, 07 Jul 2009 21\:23\:25 -0400") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Brian, >> + struct { >> + char saddr[16]; >> + char rcv_saddr[16]; >> + char daddr[16]; >> + } inet6 __attribute__ ((aligned(8))); BH> These should be 'struct in6_addr'. Okay. BH> And just like in your IPv4 section you need a FIXME here for the BH> things you skipped :) Heh, okay :) BH> There's an inline called ipv6_addr_copy() that will do the same BH> thing, then you could drop the alen argument. Okay, cool. Thanks! -- Dan Smith IBM Linux Technology Center email: danms-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org