From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF8093559EC for ; Tue, 6 Jan 2026 19:12:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767726781; cv=none; b=R+L9basllmnn4UgMWQBUNQULBGgpzln5IbBeNCTU+txMfICrUWLgQkmF4uezSIlNu38WSEvk0Ly6I6oEKCLRawSvpiqxhFOo0wUUPUfnZ7dGmGlno+T2Yq1efk1zPweSrMGHss55D2RG8FDiclM4ZBCOXWFKkoycsRPsJziBbHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767726781; c=relaxed/simple; bh=MTcyF5b+m7Nyqandj8JtczWsOLQSOo5LeGjHtbxWriw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=jxLHV7k9mZhtnt2YRK7+3pKlm7WCv/iqnZJrE/Ty4OQX/ds4/IkQS050pxk8YlnywlF0hPecGZMUzru/ouPCgdfGMT8ojOtubGTQzjHmdEI7rAjGvbYAG/XprLWM8RI5O1vklD+GshizyloliOe1hoPBKfiDRhXcMpqCReBnkyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=J1ZBZfYB; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="J1ZBZfYB" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b76b5afdf04so243274566b.1 for ; Tue, 06 Jan 2026 11:12:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1767726778; x=1768331578; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=NXWpgxUwvI+z5T2g0AYqNsPXHVO8gEezrOfJieXUNiU=; b=J1ZBZfYBN/5Aqgd1hJT8EvXHE+m2mSbf6ghC7xxsR/O1bXxPVJ9TeF09lQq4rWbeBO W2yCD7rvqI7+UWO/1L3W6rkbGBDygal0nssDjKyOx5s/YnfXTO9M+AczvxNQ75uzKMc2 OwMmdZ0Vahj4gAClUs1TJwdUNOrhudbVmfX+BLn23ratB5M5tkJHTf/8eltiEBCqx5YV 3Ilo+c+2VjixeugzzvRvdEaeP1Ps5I3GqnkkreyGoCqs3YQAW5S//rzUHzCWTyNG41aF 3kOBAYZ0l7Dr4nPgk42BPmU9s8ZOVkO1qg6GR4xm1poKxokoqPodgDAjifDaE3x7/nK5 Jyhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767726778; x=1768331578; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=NXWpgxUwvI+z5T2g0AYqNsPXHVO8gEezrOfJieXUNiU=; b=CwUwP9AnpLhTwhVESCuPGtqy6OH8COOpmvwpXhKirB/2o6nijnkrbiqWLt31oJA4Of 83UuMUtoN4iifQNIg20vTwwdw6VdSuQjjSrf5Spt1umHLt6eTfQtYyB3rnQuRfzUvvpr 7psNeHDiTbKur5d67rp13N3thGSANlQyIiZBSGuknBiPCVXAFSdV9q07jEu6/RGcmYSO w6SIhgFgBEALughPM+NBT3xbKX+l2GA8T3Qd5CkYXqB6ppJUFfeAr6l9dsKFTg1Kpeu3 ActIfaSyCgrYeiKCW4WcBB+lc7RYX4KYraFyyW5rCCnhyxF9ilwuVEnPFskcD/LWGdvv TH0A== X-Forwarded-Encrypted: i=1; AJvYcCUaU89AiWxkK2cYJiI2NhTjYnxofVtHXlKrRd105mr1fYwQauhAAd/et9EXJvDVKszpi8C8xpg=@vger.kernel.org X-Gm-Message-State: AOJu0YyobVmcAYfxrgp+249YPLv7e88qstSXflkLqFi1AHjDa2kVKS0K Ns95B1LFbKi9d/SITvuss0ZiHCm7+KqMEpg66Lus/vcuQ+CP5yyMbs7TWdMMDR1yaRI= X-Gm-Gg: AY/fxX4Cs7dz6qiEAPz+AfkgXGrhtL7cADApn+OhZQFqkcetw9aMxb032Noe2ZjQ9VD 4S9t6D7XfWMB3IFthb0X5JQR5OsrEFobaTbP1JekkmZxyeMDMASD2J/vz44lFvxoLF1IJKHrGfM XD6jZBlQnROF9LPVMXQ8A/sEOusl9tjc30EWZqx0ah9HxrZ0mpKdlYA0AA+2kkRVZJS3k/We2W6 95+uJ8V55GguS7O7rFYZhgK4kME7gmC9+6MLQTpAZcCzsA5C4GZr8GO5mQ2Q3d+MUub5UlWxheg JsO/Vxqy2g3uabUjkyOPmSYs085+aQzTkdKblvDj+mxqRwpjURxua68sltJ0pSonuimjt9JVxcD lP1sSPHUOfdRt7FaFayegF+iqi+5V0raorE+Fu1ZdsS+2A1WBuTnqAjyVEDCCFbRVzoFUKTPJ+/ gy3w== X-Google-Smtp-Source: AGHT+IE3z7Gjd92GDSE6PNW2kogYeyhE4xgee7+KnxQ3/NwdbhBSJKfxfIGkZrdtzTRaaf5Uhcw0Uw== X-Received: by 2002:a17:907:3d0b:b0:b83:1326:7d45 with SMTP id a640c23a62f3a-b8445345f6dmr14494766b.32.1767726778155; Tue, 06 Jan 2026 11:12:58 -0800 (PST) Received: from cloudflare.com ([2a09:bac5:5063:295f::41f:a]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b842a4d0290sm291076166b.32.2026.01.06.11.12.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Jan 2026 11:12:57 -0800 (PST) From: Jakub Sitnicki To: Amery Hung , Alexei Starovoitov , Martin KaFai Lau Cc: Martin KaFai Lau , bpf , Network Development , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Simon Horman , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , kernel-team Subject: Re: [PATCH bpf-next v2 15/16] bpf: Realign skb metadata for TC progs using data_meta In-Reply-To: (Amery Hung's message of "Tue, 6 Jan 2026 09:46:49 -0800") References: <20260105-skb-meta-safeproof-netdevs-rx-only-v2-0-a21e679b5afa@cloudflare.com> <20260105-skb-meta-safeproof-netdevs-rx-only-v2-15-a21e679b5afa@cloudflare.com> <877btu8wz2.fsf@cloudflare.com> Date: Tue, 06 Jan 2026 20:12:56 +0100 Message-ID: <87qzs2imh3.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Tue, Jan 06, 2026 at 09:46 AM -08, Amery Hung wrote: > On Tue, Jan 6, 2026 at 9:36=E2=80=AFAM Jakub Sitnicki wrote: >> --- a/kernel/bpf/verifier.c >> +++ b/kernel/bpf/verifier.c >> @@ -21806,6 +21806,14 @@ static int convert_ctx_accesses(struct bpf_veri= fier_env *env) >> env->prog =3D new_prog; >> delta +=3D cnt - 1; >> >> + /* gen_prologue emits function calls with target= address >> + * relative to __bpf_call_base. Skip patch_call_= imm fixup. >> + */ >> + for (i =3D 0; i < cnt - 1; i++) { >> + if (bpf_helper_call(&env->prog->insnsi[i= ])) >> + env->insn_aux_data[i].finalized_= call =3D true; >> + } >> + >> ret =3D add_kfunc_in_insns(env, insn_buf, cnt - = 1); > > And then we can get rid of this function as there is no use case for > having a new kfunc in gen_{pro,epi}logue. Happy to convert bpf_{qdisc,testmod} gen_{pro,epi}logue to use BPF_EMIT_CALL instead of BPF_CALL_KFUNC. If it's alright with you, I'd like to kill kfunc support in {pro,epi}logue as a follow up. Looks like there will be a bit of churn in selftests to remove the coverage. And this series is getting quite long.