From: Jakub Sitnicki <jakub@cloudflare.com>
To: Yaxin Chen <yaxin.chen1@bytedance.com>
Cc: netdev@vger.kernel.org, bpf@vger.kernel.org,
Cong Wang <cong.wang@bytedance.com>,
John Fastabend <john.fastabend@gmail.com>
Subject: Re: [Patch net-next] tcp_bpf: remove an unused parameter for bpf_tcp_ingress()
Date: Thu, 29 Aug 2024 17:56:33 +0200 [thread overview]
Message-ID: <87r0a7uxu6.fsf@cloudflare.com> (raw)
In-Reply-To: <20240823224843.1985277-1-yaxin.chen1@bytedance.com> (Yaxin Chen's message of "Fri, 23 Aug 2024 15:48:43 -0700")
On Fri, Aug 23, 2024 at 03:48 PM -07, Yaxin Chen wrote:
> Parameter flags is not used in bpf_tcp_ingress().
>
> Reviewed-by: Cong Wang <cong.wang@bytedance.com>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: Jakub Sitnicki <jakub@cloudflare.com>
> Signed-off-by: Yaxin Chen <yaxin.chen1@bytedance.com>
> ---
First introduced in commit 8934ce2fd081 ("bpf: sockmap redirect ingress
support") [1]. Looks like it was never in use from the beginning.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=8934ce2fd08171e8605f7fada91ee7619fe17ab8
Acked-by: Jakub Sitnicki <jakub@cloudflare.com>
next prev parent reply other threads:[~2024-08-29 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 22:48 [Patch net-next] tcp_bpf: remove an unused parameter for bpf_tcp_ingress() Yaxin Chen
2024-08-26 21:49 ` Jakub Kicinski
2024-08-27 21:50 ` Martin KaFai Lau
2024-08-29 15:56 ` Jakub Sitnicki [this message]
2024-09-02 16:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0a7uxu6.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yaxin.chen1@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).