From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
"Arnd Bergmann" <arnd@arndb.de>,
"Jiri Pirko" <jiri@resnulli.us>,
"Arnd Bergmann" <arnd@kernel.org>,
Netdev <netdev@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, linux-wpan@vger.kernel.org,
"Michael Hennerich" <michael.hennerich@analog.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
"Rodolfo Zitellini" <rwz@xhero.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional
Date: Sat, 14 Oct 2023 08:00:51 +0300 [thread overview]
Message-ID: <87r0lxer24.fsf@kernel.org> (raw)
In-Reply-To: <20231013170732.587afd86@kernel.org> (Jakub Kicinski's message of "Fri, 13 Oct 2023 17:07:32 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> On Wed, 11 Oct 2023 17:57:38 +0200 Arnd Bergmann wrote:
>> The .ndo_do_ioctl() netdev operation used to be how one communicates
>> with a network driver from userspace, but since my previous cleanup [1],
>> it is purely internal to the kernel.
>>
>> Removing the cops appletalk/localtalk driver made me revisit the
>> missing pieces from that older series, removing all the unused
>> implementations in wireless drivers as well as the two kernel-internal
>> callers in the ieee802154 and appletalk stacks.
>>
>> One ethernet driver was already merged in the meantime that should
>> have used .ndo_eth_ioctl instead of .ndo_do_ioctl, so fix that as well.
>> With the complete removal, any future drivers making this mistake
>> cause build failures that are easier to spot.
>>
>> [1] https://lore.kernel.org/netdev/20201106221743.3271965-1-arnd@kernel.org/
>
> Kalle, Johannes, do these apply for you?
> I'm getting a small conflict on patch 8 and bigger one on patch 9.
Yes, 'git am -3' was able to solve the conflicts automatically and these
do apply to wireless-next.
> If this applies for you maybe you can take it and flush out
> wireless-next soon after?
Ok, we'll do that. Does next Wednesday sound soon enough? :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-10-14 4:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 14:02 [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 02/10] ieee802154: avoid deprecated .ndo_do_ioctl callback Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 03/10] ethernet: sp7021: fix ioctl callback pointer Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 04/10] staging: ks7010: remove unused ioctl handler Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 05/10] staging: rtl8192: remove unused legacy ioctl handlers Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 06/10] staging: rtl8712: " Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 07/10] staging: rtl8723bs: remove dead code Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 08/10] wifi: atmel: remove unused ioctl function Arnd Bergmann
2023-10-14 6:42 ` Kalle Valo
2023-10-11 14:02 ` [PATCH v2 09/10] wifi: hostap: " Arnd Bergmann
2023-10-11 14:02 ` [PATCH v2 10/10] net: remove ndo_do_ioctl handler Arnd Bergmann
2023-10-11 15:04 ` [PATCH v2 01/10] appletalk: make localtalk and ppp support conditional Jiri Pirko
2023-10-11 15:57 ` Arnd Bergmann
2023-10-12 13:46 ` Jiri Pirko
2023-10-14 0:07 ` Jakub Kicinski
2023-10-14 5:00 ` Kalle Valo [this message]
2023-10-18 0:22 ` Jakub Kicinski
2023-10-18 0:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0lxer24.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rwz@xhero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).