From: Petr Machata <petrm@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: Petr Machata <petrm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
Roopa Prabhu <roopa@nvidia.com>, <netdev@vger.kernel.org>,
<bridge@lists.linux-foundation.org>,
Ido Schimmel <idosch@nvidia.com>
Subject: Re: [PATCH net-next mlxsw v2 08/16] net: bridge: Add netlink knobs for number / maximum MDB entries
Date: Thu, 2 Feb 2023 16:02:20 +0100 [thread overview]
Message-ID: <87r0v8ds8m.fsf@nvidia.com> (raw)
In-Reply-To: <14fac71d-dc43-bc5c-4d77-3187e066cfc0@blackwall.org>
Nikolay Aleksandrov <razor@blackwall.org> writes:
> On 02/02/2023 10:52, Nikolay Aleksandrov wrote:
>> On 01/02/2023 19:28, Petr Machata wrote:
>>> +int br_multicast_vlan_ngroups_set_max(struct net_bridge *br,
>>> + struct net_bridge_vlan *v, u32 max,
>>> + struct netlink_ext_ack *extack)
>>> +{
>>> + if (br_multicast_port_ctx_vlan_disabled(&v->port_mcast_ctx)) {
>>> + NL_SET_ERR_MSG_MOD(extack, "Multicast snooping disabled on this VLAN");
>>> + return -EINVAL;
>>> + }
>>
>> same comment about the check
>
> Ok, not exactly the same. I see that for the max case this check is used, please pull it
> in the vlan code and just drop this helper. Both read/write will be doing the same then.
OK. This actually simplifies the code quite a bit.
next prev parent reply other threads:[~2023-02-02 15:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 17:28 [PATCH net-next mlxsw v2 00/16] bridge: Limit number of MDB entries per port, port-vlan Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 01/16] net: bridge: Set strict_start_type at two policies Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 02/16] net: bridge: Add extack to br_multicast_new_port_group() Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 03/16] net: bridge: Move extack-setting " Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 04/16] net: bridge: Add br_multicast_del_port_group() Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 05/16] net: bridge: Change a cleanup in br_multicast_new_port_group() to goto Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 06/16] net: bridge: Add a tracepoint for MDB overflows Petr Machata
2023-02-02 16:22 ` Steven Rostedt
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 07/16] net: bridge: Maintain number of MDB entries in net_bridge_mcast_port Petr Machata
2023-02-02 8:56 ` Nikolay Aleksandrov
2023-02-02 8:57 ` Nikolay Aleksandrov
2023-02-02 10:09 ` Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 08/16] net: bridge: Add netlink knobs for number / maximum MDB entries Petr Machata
2023-02-02 8:52 ` Nikolay Aleksandrov
2023-02-02 9:02 ` Nikolay Aleksandrov
2023-02-02 15:02 ` Petr Machata [this message]
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 09/16] selftests: forwarding: Move IGMP- and MLD-related functions to lib Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 10/16] selftests: forwarding: bridge_mdb: Fix a typo Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 11/16] selftests: forwarding: lib: Add helpers for IP address handling Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 12/16] selftests: forwarding: lib: Add helpers for checksum handling Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 13/16] selftests: forwarding: lib: Parameterize IGMPv3/MLDv2 generation Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 14/16] selftests: forwarding: lib: Allow list of IPs for IGMPv3/MLDv2 Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 15/16] selftests: forwarding: lib: Add helpers to build IGMP/MLD leave packets Petr Machata
2023-02-01 17:28 ` [PATCH net-next mlxsw v2 16/16] selftests: forwarding: bridge_mdb_max: Add a new selftest Petr Machata
2023-02-01 18:25 ` [PATCH net-next mlxsw v2 00/16] bridge: Limit number of MDB entries per port, port-vlan Jakub Kicinski
2023-02-02 10:07 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0v8ds8m.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).