From: Kalle Valo <kvalo@kernel.org>
To: Meng Tang <tangmeng@uniontech.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ipw2x00: use DEVICE_ATTR_*() macro
Date: Wed, 06 Apr 2022 12:58:31 +0300 [thread overview]
Message-ID: <87r16apm7s.fsf@kernel.org> (raw)
In-Reply-To: <20220406015444.14408-1-tangmeng@uniontech.com> (Meng Tang's message of "Wed, 6 Apr 2022 09:54:44 +0800")
Meng Tang <tangmeng@uniontech.com> writes:
> Use DEVICE_ATTR_*() helper instead of plain DEVICE_ATTR,
> which makes the code a bit shorter and easier to read.
>
> Signed-off-by: Meng Tang <tangmeng@uniontech.com>
> ---
> drivers/net/wireless/intel/ipw2x00/ipw2100.c | 64 +++++-----
> drivers/net/wireless/intel/ipw2x00/ipw2200.c | 119 +++++++++----------
> 2 files changed, 90 insertions(+), 93 deletions(-)
You have submitted a similar (or identical?) patch earlier:
https://patchwork.kernel.org/project/linux-wireless/patch/20220401053138.17749-1-tangmeng@uniontech.com/
If you submit a new patch mark it as v2 and include a changelog. Please
read our documentation:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#changelog_missing
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-04-06 13:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 1:54 [PATCH net] ipw2x00: use DEVICE_ATTR_*() macro Meng Tang
2022-04-06 5:23 ` Kalle Valo
2022-04-06 9:58 ` Kalle Valo [this message]
2022-04-06 12:16 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r16apm7s.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tangmeng@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).