From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>, bpf@vger.kernel.org
Cc: netdev@vger.kernel.org, "Jiri Benc" <jbenc@redhat.com>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Eelco Chaudron" <echaudro@redhat.com>,
ast@kernel.org, "Daniel Borkmann" <daniel@iogearbox.net>,
"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>,
"David Ahern" <dsahern@gmail.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Björn Töpel" <bjorn.topel@gmail.com>,
"Hangbin Liu" <liuhangbin@gmail.com>
Subject: Re: [PATCHv7 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support
Date: Wed, 14 Apr 2021 16:16:36 +0200 [thread overview]
Message-ID: <87r1jdkl2z.fsf@toke.dk> (raw)
In-Reply-To: <20210414122610.4037085-1-liuhangbin@gmail.com>
Hangbin Liu <liuhangbin@gmail.com> writes:
> Hi,
>
> This patchset is a new implementation for XDP multicast support based
> on my previous 2 maps implementation[1]. The reason is that Daniel think
> the exclude map implementation is missing proper bond support in XDP
> context. And there is a plan to add native XDP bonding support. Adding a
> exclude map in the helper also increase the complex of verifier and has
> draw back of performace.
>
> The new implementation just add two new flags BPF_F_BROADCAST and
> BPF_F_EXCLUDE_INGRESS to extend xdp_redirect_map for broadcast support.
>
> With BPF_F_BROADCAST the packet will be broadcasted to all the interfaces
> in the map. with BPF_F_EXCLUDE_INGRESS the ingress interface will be
> excluded when do broadcasting.
Alright, I'm out of things to complain about - thanks for sticking with
it! :)
For the series:
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
prev parent reply other threads:[~2021-04-14 14:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 12:26 [PATCHv7 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support Hangbin Liu
2021-04-14 12:26 ` [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-04-15 0:17 ` Martin KaFai Lau
2021-04-15 2:37 ` Hangbin Liu
2021-04-15 9:22 ` Toke Høiland-Jørgensen
2021-04-15 17:35 ` Martin KaFai Lau
2021-04-15 18:21 ` Jesper Dangaard Brouer
2021-04-15 20:29 ` Toke Høiland-Jørgensen
2021-04-16 0:39 ` Martin KaFai Lau
2021-04-16 10:03 ` Toke Høiland-Jørgensen
2021-04-16 18:20 ` Martin KaFai Lau
2021-04-16 13:45 ` Jesper Dangaard Brouer
2021-04-16 14:35 ` Toke Høiland-Jørgensen
2021-04-16 18:22 ` Martin KaFai Lau
2021-04-17 0:23 ` Paul E. McKenney
2021-04-17 12:27 ` Toke Høiland-Jørgensen
2021-04-19 16:58 ` Paul E. McKenney
2021-04-19 18:12 ` Toke Høiland-Jørgensen
2021-04-19 18:32 ` Paul E. McKenney
2021-04-19 21:21 ` Toke Høiland-Jørgensen
2021-04-19 21:41 ` Paul E. McKenney
2021-04-19 22:16 ` Toke Høiland-Jørgensen
2021-04-19 22:31 ` Paul E. McKenney
2021-04-21 14:24 ` Toke Høiland-Jørgensen
2021-04-21 14:59 ` Paul E. McKenney
2021-04-21 19:59 ` Toke Høiland-Jørgensen
2021-04-21 20:51 ` Paul E. McKenney
2021-04-21 21:10 ` Toke Høiland-Jørgensen
2021-04-21 21:30 ` Paul E. McKenney
2021-04-21 22:00 ` Toke Høiland-Jørgensen
2021-04-21 22:31 ` Paul E. McKenney
2021-04-22 14:30 ` Toke Høiland-Jørgensen
2021-04-14 12:26 ` [PATCHv7 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support Hangbin Liu
2021-04-15 0:23 ` Martin KaFai Lau
2021-04-15 2:21 ` Hangbin Liu
2021-04-15 9:29 ` Toke Høiland-Jørgensen
2021-04-14 12:26 ` [PATCHv7 bpf-next 3/4] sample/bpf: add xdp_redirect_map_multi for redirect_map broadcast test Hangbin Liu
2021-04-14 12:26 ` [PATCHv7 bpf-next 4/4] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-04-14 14:16 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1jdkl2z.fsf@toke.dk \
--to=toke@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=echaudro@redhat.com \
--cc=jbenc@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=liuhangbin@gmail.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).