From: Vlad Buslov <vlad@buslov.dev>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: David Ahern <dsahern@gmail.com>, Vlad Buslov <vladbu@nvidia.com>,
netdev@vger.kernel.org, Vlad Buslov <vladbu@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [RESEND PATCH iproute2-next 2/2] tc: implement support for terse dump
Date: Wed, 30 Sep 2020 23:11:26 +0300 [thread overview]
Message-ID: <87r1qj6n4i.fsf@buslov.dev> (raw)
In-Reply-To: <20200930103359.1fa698fd@hermes.local>
On Wed 30 Sep 2020 at 20:33, Stephen Hemminger <stephen@networkplumber.org> wrote:
> On Wed, 30 Sep 2020 08:57:20 -0700
> David Ahern <dsahern@gmail.com> wrote:
>
>> On 9/30/20 12:36 AM, Vlad Buslov wrote:
>> > From: Vlad Buslov <vladbu@mellanox.com>
>> >
>> > Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS
>> > tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when
>> > user requested it with following example CLI:
>> >
>> >> tc -s filter show terse dev ens1f0 ingress
>>
>> this should be consistent with ip command which has -br for 'brief'
>> output. so this should be
>>
>> tc -s -br filter show dev ens1f0 ingress
>>
>> Other tc maintainers should weigh in on what data should be presented
>> for this mode.
>
> Current ip brief mode is good, one line per interface. Something similar with tc
> would be best.
Hi Stephen,
My proposed implementation is very simple because it relies on existing
infrastructure that omits printing data that is not included in the
netlink packet. Making terse/brief dump output one line per filter would
require extending every single classifier with either standalone
callback for such print or dedicated block in existing print_op().
Moreover, it would be complicated for me to decide what should be
included in such output for many classifiers that I don't have
experience using.
Do you think complicating implementation like that is worth it?
Regards,
Vlad
next prev parent reply other threads:[~2020-09-30 20:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 7:36 [RESEND PATCH iproute2-next 0/2] Implement filter terse dump mode support Vlad Buslov
2020-09-30 7:36 ` [RESEND PATCH iproute2-next 1/2] tc: skip actions that don't have options attribute when printing Vlad Buslov
2020-09-30 7:36 ` [RESEND PATCH iproute2-next 2/2] tc: implement support for terse dump Vlad Buslov
2020-09-30 15:57 ` David Ahern
2020-09-30 17:02 ` Vlad Buslov
2020-09-30 17:33 ` Stephen Hemminger
2020-09-30 20:11 ` Vlad Buslov [this message]
2020-09-30 11:31 ` [RESEND PATCH iproute2-next 0/2] Implement filter terse dump mode support Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1qj6n4i.fsf@buslov.dev \
--to=vlad@buslov.dev \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vladbu@mellanox.com \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).