From: Petr Machata <petrm@mellanox.com>
To: Briana Oursler <briana.oursler@gmail.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Davide Caratti <dcaratti@redhat.com>,
Stefano Brivio <sbrivio@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] tc: Add space after format specifier
Date: Tue, 28 Jul 2020 15:24:44 +0200 [thread overview]
Message-ID: <87r1svhiw3.fsf@mellanox.com> (raw)
In-Reply-To: <20200728052048.7485-1-briana.oursler@gmail.com>
Briana Oursler <briana.oursler@gmail.com> writes:
> Add space after format specifier in print_string call. Fixes broken
> qdisc tests within tdc testing suite. Per suggestion from Petr Machata,
> remove a space and change spacing in tc/q_event.c to complete the fix.
>
> Tested fix in tdc using:
> ./tdc.py -c qdisc
>
> All qdisc RED tests return ok.
>
> Fixes: d0e450438571("tc: q_red: Add support for
> qevents "mark" and "early_drop")
>
> Signed-off-by: Briana Oursler <briana.oursler@gmail.com>
Tested-by: Petr Machata <petrm@mellanox.com>
Thanks for taking care of this!
next prev parent reply other threads:[~2020-07-28 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 4:46 Question Print Formatting iproute2 Briana Oursler
2020-07-27 19:31 ` Petr Machata
2020-07-27 20:37 ` Stephen Hemminger
2020-07-28 4:12 ` Briana Oursler
2020-07-27 23:47 ` Stephen Hemminger
2020-07-28 4:14 ` Briana Oursler
2020-07-28 5:20 ` [PATCH iproute2] tc: Add space after format specifier Briana Oursler
2020-07-28 5:53 ` Briana Oursler
2020-07-29 15:24 ` David Ahern
2020-07-28 13:24 ` Petr Machata [this message]
2020-07-29 17:07 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1svhiw3.fsf@mellanox.com \
--to=petrm@mellanox.com \
--cc=briana.oursler@gmail.com \
--cc=dcaratti@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).