From: "Bjørn Mork" <bjorn@mork.no>
To: "Jörgen Storvist" <jorgen.storvist@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3] qmi_wwan: Added support for Fibocom NL668 series
Date: Tue, 11 Dec 2018 21:56:19 +0100 [thread overview]
Message-ID: <87r2enlr4c.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20181211164925.000031d3@gmail.com> ("Jörgen Storvist"'s message of "Tue, 11 Dec 2018 16:49:25 +0100")
Jörgen Storvist <jorgen.storvist@gmail.com> writes:
> Added support for Fibocom NL668 series QMI WWAN interface in default USB mode: AT+GTUSBMODE=17.
> Using QMI_QUIRK_SET_DTR required by Qualcomm MDM9x07 chipsets.
>
> Signed-off-by: Jörgen Storvist <jorgen.storvist@gmail.com>
> ---
>
> Changelog:
> v2: list order to correpond to USB VID/PID values.
> v3: Fixed Patch formatting.
>
> Thanks Bjørn for the inputs!
> Hopefully I managed to get it somewhat okay this time.
>
> drivers/net/usb/qmi_wwan.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index 72a55b6..dada68f 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1117,6 +1117,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x1435, 0xd181, 4)}, /* Wistron NeWeb D18Q1 */
> {QMI_FIXED_INTF(0x1435, 0xd181, 5)}, /* Wistron NeWeb D18Q1 */
> {QMI_FIXED_INTF(0x1435, 0xd191, 4)}, /* Wistron NeWeb D19Q1 */
> + {QMI_QUIRK_SET_DTR(0x1508, 0x1001, 4)}, /* Fibocom NL668 series */
> {QMI_FIXED_INTF(0x16d8, 0x6003, 0)}, /* CMOTech 6003 */
> {QMI_FIXED_INTF(0x16d8, 0x6007, 0)}, /* CMOTech CHE-628S */
> {QMI_FIXED_INTF(0x16d8, 0x6008, 0)}, /* CMOTech CMU-301 */
Looks good. Only minor thing is this warning I got from git, due to
your latin1 email:
Warning: commit message did not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitencoding to the encoding your project uses.
Don't know if that matters though. The commit message still looks fine
in utf8, so I guess not.
Acked-by: Bjørn Mork <bjorn@mork.no>
prev parent reply other threads:[~2018-12-11 20:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 22:57 [PATCH] qmi_wwan: Added support for Fibocom NL668 series Jörgen Storvist
2018-12-10 13:52 ` Bjørn Mork
2018-12-11 13:49 ` [PATCH v2] " Jörgen Storvist
2018-12-11 14:12 ` Bjørn Mork
2018-12-11 15:49 ` [PATCH v3] " Jörgen Storvist
2018-12-11 20:56 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2enlr4c.fsf@miraculix.mork.no \
--to=bjorn@mork.no \
--cc=jorgen.storvist@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).