From: Kalle Valo <kvalo@codeaurora.org>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"David S. Miller" <davem@davemloft.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Add a missing break in parse_station_flags
Date: Mon, 23 Jul 2018 12:30:41 +0300 [thread overview]
Message-ID: <87r2juti2m.fsf@purkki.adurom.net> (raw)
In-Reply-To: <AM5PR0701MB265751E3A716081292C5224FE4450@AM5PR0701MB2657.eurprd07.prod.outlook.com> (Bernd Edlinger's message of "Sun, 8 Jul 2018 09:57:22 +0000")
Bernd Edlinger <bernd.edlinger@hotmail.de> writes:
> I was looking at usually suppressed gcc warnings,
> [-Wimplicit-fallthrough=] in this case:
>
> The code definitely looks like a break is missing here.
> However I am not able to test the NL80211_IFTYPE_MESH_POINT,
> nor do I actually know what might be :)
> So please use this patch with caution and only if you are
> able to do some testing.
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
> ---
> net/wireless/nl80211.c | 1 +
> 1 file changed, 1 insertion(+)
You should use prefix "nl80211: " in the title.
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject
--
Kalle Valo
prev parent reply other threads:[~2018-07-23 9:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 9:57 [PATCH] Add a missing break in parse_station_flags Bernd Edlinger
2018-07-23 9:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2juti2m.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=bernd.edlinger@hotmail.de \
--cc=davem@davemloft.net \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox