From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] rsi: Remove stack VLA usage Date: Fri, 09 Mar 2018 12:37:06 +0200 Message-ID: <87r2ota625.fsf@codeaurora.org> References: <1520577493-24603-1-git-send-email-me@tobin.cc> Mime-Version: 1.0 Content-Type: text/plain Cc: kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Tycho Andersen , Kees Cook , "Gustavo A. R. Silva" To: "Tobin C. Harding" Return-path: In-Reply-To: <1520577493-24603-1-git-send-email-me@tobin.cc> (Tobin C. Harding's message of "Fri, 9 Mar 2018 17:38:13 +1100") Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org "Tobin C. Harding" writes: > The kernel would like to have all stack VLA usage removed[1]. rsi uses > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > is defined using a magic number. We can use a pre-processor defined > constant and declare the array to maximum size. We add a check before > accessing the array in case of programmer error. > > [1]: https://lkml.org/lkml/2018/3/7/621 > > Signed-off-by: Tobin C. Harding Please CC linux-wireless list, otherwise patchwork won't see the patch and I can't apply it. -- Kalle Valo