netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging
@ 2016-03-25 17:01 Vivien Didelot
  2016-03-25 17:20 ` Vivien Didelot
  0 siblings, 1 reply; 3+ messages in thread
From: Vivien Didelot @ 2016-03-25 17:01 UTC (permalink / raw)
  To: netdev; +Cc: linux-kernel, kernel, David S. Miller, Andrew Lunn,
	Vivien Didelot

The 88E6185 switch also has a MapDA bit in its Port Control 2 register.
When this bit is cleared, all frames are sent out to the CPU port.

Set this bit to rely on ATU hits and direct the frame out of the correct
ports, and thus enable hardware bridging.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 drivers/net/dsa/mv88e6xxx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
index 4332b15..85ed3e2 100644
--- a/drivers/net/dsa/mv88e6xxx.c
+++ b/drivers/net/dsa/mv88e6xxx.c
@@ -2586,7 +2586,8 @@ static int mv88e6xxx_setup_port(struct dsa_switch *ds, int port)
 	reg = 0;
 	if (mv88e6xxx_6352_family(ds) || mv88e6xxx_6351_family(ds) ||
 	    mv88e6xxx_6165_family(ds) || mv88e6xxx_6097_family(ds) ||
-	    mv88e6xxx_6095_family(ds) || mv88e6xxx_6320_family(ds))
+	    mv88e6xxx_6095_family(ds) || mv88e6xxx_6320_family(ds) ||
+	    mv88e6xxx_6185_family(ds))
 		reg = PORT_CONTROL_2_MAP_DA;
 
 	if (mv88e6xxx_6352_family(ds) || mv88e6xxx_6351_family(ds) ||
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging
  2016-03-25 17:01 [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging Vivien Didelot
@ 2016-03-25 17:20 ` Vivien Didelot
  2016-03-25 19:01   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Vivien Didelot @ 2016-03-25 17:20 UTC (permalink / raw)
  To: netdev; +Cc: linux-kernel, kernel, David S. Miller, Andrew Lunn

Hi,

Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:

> The 88E6185 switch also has a MapDA bit in its Port Control 2 register.
> When this bit is cleared, all frames are sent out to the CPU port.
>
> Set this bit to rely on ATU hits and direct the frame out of the correct
> ports, and thus enable hardware bridging.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>

Andrew, I sent this patch too fast. It requires a proper support of the
ATU in order to populate the FDB correctly. I send that soon.

David, please ignore this patch for the moment.

Thanks,
Vivien

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging
  2016-03-25 17:20 ` Vivien Didelot
@ 2016-03-25 19:01   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2016-03-25 19:01 UTC (permalink / raw)
  To: vivien.didelot; +Cc: netdev, linux-kernel, kernel, andrew

From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Fri, 25 Mar 2016 13:20:30 -0400

> David, please ignore this patch for the moment.

Ok.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-03-25 19:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-25 17:01 [PATCH net-next] net: dsa: mv88e6xxx: fix 6185 hardware bridging Vivien Didelot
2016-03-25 17:20 ` Vivien Didelot
2016-03-25 19:01   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).