netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	Alexander Duyck <alexander.h.duyck@intel.com>
Subject: Re: [NET-NEXT PATCH 1/5] igb: link up/down messages must follow a specific format
Date: Thu, 27 Nov 2008 11:50:45 +0100	[thread overview]
Message-ID: <87r64x30je.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081127000206.22431.53339.stgit@gitlost.lost> (Jeff Kirsher's message of "Wed, 26 Nov 2008 16:02:06 -0800")

Jeff Kirsher <jeffrey.t.kirsher@intel.com> writes:

> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> The system log messages created on a link status change need to follow a
> specific format to work with tools some customers use.

It would be better to define standard helper functions that output this
format somewhere. Then this could be also used in other drivers.

-Andi

-- 
ak@linux.intel.com

  parent reply	other threads:[~2008-11-27 10:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-27  0:02 [NET-NEXT PATCH 1/5] igb: link up/down messages must follow a specific format Jeff Kirsher
2008-11-27  0:02 ` [NET-NEXT PATCH 2/5] ixgbe: cleanup link up/down messages Jeff Kirsher
2008-11-27  8:22   ` David Miller
2008-11-27  0:02 ` [NET-NEXT PATCH 3/5] e1000: " Jeff Kirsher
2008-11-27  8:22   ` David Miller
2008-11-27  0:02 ` [NET-NEXT PATCH 4/5] ixgb: " Jeff Kirsher
2008-11-27  8:23   ` David Miller
2008-11-27  0:03 ` [NET-NEXT PATCH 5/5] e100: " Jeff Kirsher
2008-11-27  8:23   ` David Miller
2008-11-27  8:21 ` [NET-NEXT PATCH 1/5] igb: link up/down messages must follow a specific format David Miller
2008-11-27 10:50 ` Andi Kleen [this message]
2008-11-27 11:34   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r64x30je.fsf@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).