From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EEF415442A for ; Tue, 21 Jan 2025 14:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737469568; cv=none; b=kpcPucXL3NwIOFgLUcFRrF//SedBsUHFRS3MPCUrXj8ZcKPoGgUxJp70ysvxn3cv79aYx8jclYnKhQoTHzyVNSEkuKkHX+cZmh4idf9LpeOeneQrKAitPyPHsckRxbZx8TrpOczu3vhVvKPeQgSMz4pLAzmNWbkYqWDd5v4oziU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737469568; c=relaxed/simple; bh=Rjp+hmWDO5OTfT2ysMv61UtgN9kBNntHkBGEm553axg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=PNZK1ExlWiQ/GhG274e+0G1w/BrhmCnaWdVaTiKf43EhK2rsDgEr1Gktaont1Aa6Sw1mvb08Y0VwfcQ4Vh7rpNgDI7bHcrdp4qOs5OHY1fBQLNIhjvO9wat82QEPNn3TSfwihfzQUG6vOU/WKqU06l0bK5vYNxVngbMv6WLPzXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=VzKJV7c5; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="VzKJV7c5" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-ab633d9582aso251047166b.1 for ; Tue, 21 Jan 2025 06:26:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1737469565; x=1738074365; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Rjp+hmWDO5OTfT2ysMv61UtgN9kBNntHkBGEm553axg=; b=VzKJV7c5sszDBE+DajCUYyQthAweExG4XCb6BMSV9Evtb2gEIZbJog4hZjLVHWd1i6 tzzSM+ZHes1R6Ip874NJNBmws8E9N/R6hxSUz2IG8bO3i1NvgEUHjglgcob5o8oCcUle gC3jz7PVEEhni6NQTY1YoyK6LuNK5cjlAfIXOeOYwts4J9iSYfI20TNrapTRW/wjbxRB 1giGF2bjoV9eHj1oDwgjtEgJKxZPUL/Cj4QFjfSz46BNs+Z2J1ZuPfQuVXlKvXS3jD3C TXpIbSeRp/Uu1UPuWc8e9+E0EXCA/sFMpNYypQHGpejE83CcyvGCJZQ+gZX6PvxedoOG 6ssg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737469565; x=1738074365; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Rjp+hmWDO5OTfT2ysMv61UtgN9kBNntHkBGEm553axg=; b=dYpv4QRF/6rZcwcfbE1fCqmrQZ5RUWlEdvK9N4SLS0QX4d4eToIgQgj4h16uV5cS22 VEdPI1wDZ4q0KLxKm4v5Kt5IVyp2jm+neqjKzxHtYybWYyYIkaXTqxG5aGecwlixWQR9 ShabCkvTu1ts1kK0yBnZRImdyRzrgawewO0YZQogB2o3XHlyvV6vBhvuLaTpdPYESYfD V+kl1bq9K7naKKVTZxCl59k2fDgsrcNXG1EkDx0txViW8lEcFbCXUE54QbhGrnVzgaQa xsmv7aVjzfjMQA/za3YpMHZdbgE0dWMTHXDm4jriPkHJlkgC/ldeTWwhmC7JRcw6ievr 3PFQ== X-Forwarded-Encrypted: i=1; AJvYcCXkxAvU7iyHCcCpWsbSXroys5L7Z9KiNfAztGlPv1yi3ogovn4UKW1HIdSI2bKeOgo/hj1RFXg=@vger.kernel.org X-Gm-Message-State: AOJu0YzGNpqfUZ3UOMBLZpNRTXt/eLg2NizucZy3OXUDtrMNU1p9HvUQ QzRNokiaHF86iLXLj0qq4mvYskRyAA9ZRJNT5gi3Sliny0PyHkimznkzjA5pbOY= X-Gm-Gg: ASbGncv9ZD5aOmJbLZrydnSd8ABQMSQXLzeq7KW1NyLx3FI8FX+wy8+BZIlBubdPJAy fKPtIgRuYqL++rDCfaAXRiHCtByKygkhz9n2IRSv9HmZvHkF/Eg/6MCMhGk+C+oI5uGOh8Bbl73 Xwkk7rzmPO58XYcFNowKS30lggwIb+S0l8psLMw6so/EPszLtrxNiR99HJcEMg1ONgARzuSDYry ElKvL5tzEIgjlOQrI35Xzy3pSRYXrcT2dpGhnH5u/bqJf9G7/nxT8g2Gkt5Ww== X-Google-Smtp-Source: AGHT+IHwlnK2zw9uivEKoPguTLSLMAAZPkuD0ILNy3EmWF7Ejd0QSjCd/rdjvIvH/M8AXJrGyDq9hg== X-Received: by 2002:a17:907:9802:b0:aae:8491:bab5 with SMTP id a640c23a62f3a-ab38b30e1admr1420221266b.26.1737469564730; Tue, 21 Jan 2025 06:26:04 -0800 (PST) Received: from cloudflare.com ([2a09:bac1:5b80:d60::38a:3e]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384ce0172sm749653166b.44.2025.01.21.06.26.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jan 2025 06:26:03 -0800 (PST) From: Jakub Sitnicki To: Jiayuan Chen Cc: bpf@vger.kernel.org, john.fastabend@gmail.com, netdev@vger.kernel.org, martin.lau@linux.dev, ast@kernel.org, edumazet@google.com, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org, song@kernel.org, andrii@kernel.org, mhal@rbox.co, yonghong.song@linux.dev, daniel@iogearbox.net, xiyou.wangcong@gmail.com, horms@kernel.org, corbet@lwn.net, eddyz87@gmail.com, cong.wang@bytedance.com, shuah@kernel.org, mykolal@fb.com, jolsa@kernel.org, haoluo@google.com, sdf@fomichev.me, kpsingh@kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH bpf v8 4/5] selftests/bpf: fix invalid flag of recv() In-Reply-To: <20250121050707.55523-5-mrpre@163.com> (Jiayuan Chen's message of "Tue, 21 Jan 2025 13:07:06 +0800") References: <20250121050707.55523-1-mrpre@163.com> <20250121050707.55523-5-mrpre@163.com> Date: Tue, 21 Jan 2025 15:26:02 +0100 Message-ID: <87sepcgs5h.fsf@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Jan 21, 2025 at 01:07 PM +08, Jiayuan Chen wrote: > SOCK_NONBLOCK flag is only effective during socket creation, not during > recv. Use MSG_DONTWAIT instead. > > Signed-off-by: Jiayuan Chen > --- Good catch. Fixes: 1fa1fe8ff161 ("bpf, sockmap: Test shutdown() correctly exits epoll and recv()=0") Reviewed-by: Jakub Sitnicki