From: "Toke Høiland-Jørgensen" <toke@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc: Johannes Berg <johannes.berg@intel.com>
Subject: Re: [RFC PATCH 1/2] net: netlink: add nla_get_*_default() accessors
Date: Thu, 24 Oct 2024 14:51:07 +0200 [thread overview]
Message-ID: <87seslfyv8.fsf@toke.dk> (raw)
In-Reply-To: <20241024131807.0a6c07355832.I3df6aac71d38a5baa1c0a03d0c7e82d4395c030e@changeid>
Johannes Berg <johannes@sipsolutions.net> writes:
> From: Johannes Berg <johannes.berg@intel.com>
>
> There are quite a number of places that use patterns
> such as
>
> if (attr)
> val = nla_get_u16(attr);
> else
> val = DEFAULT;
>
> Add nla_get_u16_default() and friends like that to
> not have to type this out all the time.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
I think this is an excellent idea! So typos/copy-paste errors aside:
Acked-by: Toke Høiland-Jørgensen <toke@kernel.org>
next prev parent reply other threads:[~2024-10-24 12:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-24 11:18 [RFC PATCH 1/2] net: netlink: add nla_get_*_default() accessors Johannes Berg
2024-10-24 11:18 ` [RFC PATCH 2/2] net: convert to nla_get_*_default() Johannes Berg
2024-10-24 12:11 ` Johannes Berg
2024-10-24 14:28 ` Sabrina Dubroca
2024-10-24 14:31 ` Johannes Berg
2024-10-24 14:40 ` Johannes Berg
2024-10-24 13:41 ` Johannes Berg
2024-10-24 14:48 ` Sabrina Dubroca
2024-10-24 14:52 ` Johannes Berg
2024-10-24 15:17 ` Sabrina Dubroca
2024-10-24 15:29 ` Johannes Berg
2024-10-29 15:57 ` Jakub Kicinski
2024-10-24 11:29 ` [RFC PATCH 1/2] net: netlink: add nla_get_*_default() accessors Johannes Berg
2024-10-24 12:51 ` Toke Høiland-Jørgensen [this message]
2024-10-29 15:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seslfyv8.fsf@toke.dk \
--to=toke@kernel.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).