From: Kalle Valo <kvalo@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <claudiu.manoil@nxp.com>,
<vladimir.oltean@nxp.com>, <louis.peens@corigine.com>,
<stefan@datenfreihafen.org>, <alex.aring@gmail.com>,
<miquel.raynal@bootlin.com>, <chunkeey@googlemail.com>,
<briannorris@chromium.org>, <francesco@dolcini.it>,
<set_pte_at@outlook.com>, <damien.lemoal@opensource.wdc.com>,
<mpe@ellerman.id.au>, <horms@kernel.org>,
<yinjun.zhang@corigine.com>, <fei.qin@corigine.com>,
<johannes.berg@intel.com>, <ryno.swart@corigine.com>,
<krzysztof.kozlowski@linaro.org>, <leitao@debian.org>,
<liuxuenetmail@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <oss-drivers@corigine.com>,
<linux-wpan@vger.kernel.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 0/7] net: Use IRQF_NO_AUTOEN flag in request_irq()
Date: Mon, 09 Sep 2024 17:39:24 +0300 [thread overview]
Message-ID: <87seu8c2n7.fsf@kernel.org> (raw)
In-Reply-To: <20240909133034.1296930-1-ruanjinjie@huawei.com> (Jinjie Ruan's message of "Mon, 9 Sep 2024 21:30:27 +0800")
Jinjie Ruan <ruanjinjie@huawei.com> writes:
> As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
> said, reqeust_irq() and then disable_irq() is unsafe.
>
> And the code below is subobtimal:
> irq_set_status_flags(irq, IRQ_NOAUTOEN);
> request_irq(dev, irq...);
>
> IRQF_NO_AUTOEN flag can be used by drivers to request_irq(). It prevents
> the automatic enabling of the requested interrupt in the same safe way.
> With that the usage can be simplified and corrected.
>
> Only compile-tested.
>
> Jinjie Ruan (7):
> net: apple: bmac: Use IRQF_NO_AUTOEN flag in request_irq()
> net: enetc: Use IRQF_NO_AUTOEN flag in request_irq()
> nfp: Use IRQF_NO_AUTOEN flag in request_irq()
> net: ieee802154: mcr20a: Use IRQF_NO_AUTOEN flag in request_irq()
> wifi: p54: Use IRQF_NO_AUTOEN flag in request_irq()
> wifi: mwifiex: Use IRQF_NO_AUTOEN flag in request_irq()
> wifi: wl1251: Use IRQF_NO_AUTOEN flag in request_irq()
>
> drivers/net/ethernet/apple/bmac.c | 3 +--
> drivers/net/ethernet/freescale/enetc/enetc.c | 3 +--
> drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 ++---
> drivers/net/ieee802154/mcr20a.c | 5 +----
> drivers/net/wireless/intersil/p54/p54spi.c | 4 +---
> drivers/net/wireless/marvell/mwifiex/main.c | 4 ++--
> drivers/net/wireless/ti/wl1251/sdio.c | 4 ++--
> 7 files changed, 10 insertions(+), 18 deletions(-)
Wireless patches go to wireless-next, please submit them in a separate
patchset.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-09-09 14:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-09 13:30 [PATCH 0/7] net: Use IRQF_NO_AUTOEN flag in request_irq() Jinjie Ruan
2024-09-09 13:30 ` [PATCH 1/7] net: apple: bmac: " Jinjie Ruan
2024-09-09 13:30 ` [PATCH 2/7] net: enetc: " Jinjie Ruan
2024-09-09 13:30 ` [PATCH 3/7] nfp: " Jinjie Ruan
2024-09-10 9:53 ` Louis Peens
2024-09-09 13:30 ` [PATCH 4/7] net: ieee802154: mcr20a: " Jinjie Ruan
2024-09-10 7:32 ` Miquel Raynal
2024-09-10 10:49 ` Stefan Schmidt
2024-09-09 13:30 ` [PATCH 5/7] wifi: p54: " Jinjie Ruan
2024-09-09 13:30 ` [PATCH 6/7] wifi: mwifiex: " Jinjie Ruan
2024-09-09 13:30 ` [PATCH 7/7] wifi: wl1251: " Jinjie Ruan
2024-09-09 14:39 ` Kalle Valo [this message]
2024-09-10 11:46 ` [PATCH 0/7] net: " Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seu8c2n7.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=alex.aring@gmail.com \
--cc=briannorris@chromium.org \
--cc=chunkeey@googlemail.com \
--cc=claudiu.manoil@nxp.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fei.qin@corigine.com \
--cc=francesco@dolcini.it \
--cc=horms@kernel.org \
--cc=johannes.berg@intel.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=liuxuenetmail@gmail.com \
--cc=louis.peens@corigine.com \
--cc=miquel.raynal@bootlin.com \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=ruanjinjie@huawei.com \
--cc=ryno.swart@corigine.com \
--cc=set_pte_at@outlook.com \
--cc=stefan@datenfreihafen.org \
--cc=vladimir.oltean@nxp.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).