From: Kalle Valo <kvalo@kernel.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org,
syzbot+92c6dd14aaa230be6855@syzkaller.appspotmail.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH V2] wifi: ath6kl: Replace ath6kl_usb_submit_ctrl_in with usb_control_msg_recv
Date: Mon, 26 Aug 2024 14:42:00 +0300 [thread overview]
Message-ID: <87seurfr3r.fsf@kernel.org> (raw)
In-Reply-To: <tencent_F0CB92D8867509922ED02ED5CCA4E7D2C606@qq.com> (Edward Adam Davis's message of "Sun, 25 Aug 2024 22:21:49 +0800")
Edward Adam Davis <eadavis@qq.com> writes:
> ath6kl_usb_submit_ctrl_in() did not take into account the situation where
> the length of the data read from the device is not equal to the len, and
> such missing judgments will result in subsequent code using incorrect data.
>
> usb_control_msg_recv() handles the abnormal length of the returned data,
> so using it directly can fix this warning.
>
> Reported-by: syzbot+92c6dd14aaa230be6855@syzkaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
Did you test this on real ath6kl hardware?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-08-26 11:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 6:11 [syzbot] [wireless?] [usb?] WARNING in ath6kl_bmi_get_target_info (2) syzbot
2024-08-25 7:10 ` [PATCH] wifi: ath6kl: Check that the read operation returns a data length of 0 Edward Adam Davis
2024-08-25 7:25 ` Greg KH
2024-08-25 8:14 ` Edward Adam Davis
2024-08-25 8:34 ` Greg KH
2024-08-25 10:09 ` Edward Adam Davis
2024-08-25 11:25 ` Greg KH
2024-08-25 14:03 ` Edward Adam Davis
2024-08-25 14:21 ` [PATCH V2] wifi: ath6kl: Replace ath6kl_usb_submit_ctrl_in with usb_control_msg_recv Edward Adam Davis
2024-08-25 14:50 ` Sergei Shtylyov
2024-08-25 15:07 ` Sergei Shtylyov
2024-08-26 5:04 ` Greg KH
2024-08-26 11:12 ` Edward Adam Davis
2024-08-26 11:19 ` [PATCH V3] " Edward Adam Davis
2024-08-26 11:25 ` Greg KH
2024-08-26 11:26 ` Greg KH
2024-08-26 12:29 ` [PATCH V4 1/2] " Edward Adam Davis
2024-08-26 13:12 ` Greg KH
2024-08-26 13:12 ` Greg KH
[not found] ` <20240826122955.2674569-3-eadavis@qq.com>
2024-08-26 12:29 ` [PATCH V4 2/2] wifi: ath6kl: remove ath6kl_usb_submit_ctrl_in Edward Adam Davis
2024-08-26 13:13 ` Greg KH
2024-08-26 13:44 ` [PATCH V5 1/2] wifi: ath6kl: Replace ath6kl_usb_submit_ctrl_in with usb_control_msg_recv Edward Adam Davis
[not found] ` <20240826134418.2744882-3-eadavis@qq.com>
2024-08-26 13:44 ` [PATCH V5 2/2] wifi: ath6kl: remove ath6kl_usb_submit_ctrl_in Edward Adam Davis
2024-08-26 13:01 ` [PATCH V4 1/2] wifi: ath6kl: Replace ath6kl_usb_submit_ctrl_in with usb_control_msg_recv Edward Adam Davis
[not found] ` <20240826130154.2706792-3-eadavis@qq.com>
2024-08-26 13:01 ` [PATCH V4 2/2] wifi: ath6kl: remove ath6kl_usb_submit_ctrl_in Edward Adam Davis
2024-08-26 11:42 ` Kalle Valo [this message]
2024-08-26 13:06 ` [PATCH V2] wifi: ath6kl: Replace ath6kl_usb_submit_ctrl_in with usb_control_msg_recv Edward Adam Davis
2024-08-26 15:01 ` Kalle Valo
2024-08-26 22:51 ` [PATCH V6 1/2] " Edward Adam Davis
[not found] ` <20240826225107.2817092-3-eadavis@qq.com>
2024-08-26 22:51 ` [PATCH V6 2/2] wifi: ath6kl: remove ath6kl_usb_submit_ctrl_in Edward Adam Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seurfr3r.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=eadavis@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=syzbot+92c6dd14aaa230be6855@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).