From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 567CE7E for ; Fri, 5 May 2023 01:43:31 +0000 (UTC) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF4F2900D; Thu, 4 May 2023 18:43:29 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id EC9723200A42; Thu, 4 May 2023 21:43:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 04 May 2023 21:43:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nikishkin.pw; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1683251004; x=1683337404; bh=/Y VNUnh3p+PgM89Dwya/IElj4KFR7bzSFhdZiIuzB3A=; b=lUA416YK92vpONrf7V L59IrPtcPDMWU2r5QlAvZhpzZQY6PtwISHSk5C6ij3aOi1axkDFcJQyY4siEkOQ4 4xemOdWOETe+aD9lH+nkSObyi/lYF9kGM89PMTkVNVBKbYUWi1EQu1HdpqC+lUZJ 0j4xzdNJpdG3eINBma0Gdyc3h6rvRsNGvSyxdVlv7tZLi6JLT6gXJyjxHYjUVUDA 9p/qior6CC4El/CrWNkplJeiEbL0P31ufTlAgVstbs64tBOoxsS/7zIrMfq5nFRD whOV3JROzTBy6PxYjs1P0xUhxfKXLBscKqLTTOLQXYcP2zO1fKFc68A+AyGTYI+3 g2MQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1683251004; x=1683337404; bh=/YVNUnh3p+PgM 89Dwya/IElj4KFR7bzSFhdZiIuzB3A=; b=J5gYOlXklohJoONvqh+Bp629jYVTZ 16BiIbENgjo+yJ1IOn9QVdDOBZsmAOKXKH9pBDZAX2W26EdWdhCfE2vRjp1tXbr0 b0sHXodki1Q0TQKQkipvAhO7D+O+A1rcpascjBGjND8Ncky9z8y78hqkEbEM9Eps FwhOn7xW+Z18LG+RL7rUp8M7OQnkzwPu128W95uL86N8sNraEaEcNHrDv8eooW1e yKx4f47wTYWzVvkk2ttEE4rOWkrrsBQobG/f5tc3AXcBRKcyQg93g8IUnELOReHZ pJVF6ZN6BlZ41bQgomsrgRKlzmgaYj1hFDuMisOWqWMJtYQOgqK0xjAEw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefuddghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdluddtmdenucfjughrpehffgfhvfevufffjgfkgggtsehttdertddt redtnecuhfhrohhmpegglhgrughimhhirhcupfhikhhishhhkhhinhcuoehvlhgrughimh hirhesnhhikhhishhhkhhinhdrphifqeenucggtffrrghtthgvrhhnpeeigfdvgeeiieel udehueeuueejieeiheegudevhffggeeguddvveduueehueefgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehvlhgrughimhhirhesnhhikhhi shhhkhhinhdrphif X-ME-Proxy: Feedback-ID: id3b446c5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 May 2023 21:43:20 -0400 (EDT) References: <20230501162530.26414-1-vladimir@nikishkin.pw> <20230501162530.26414-2-vladimir@nikishkin.pw> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Vladimir Nikishkin To: Ido Schimmel Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, eng.alaamohamedsoliman.am@gmail.com, gnault@redhat.com, razor@blackwall.org, idosch@nvidia.com, liuhangbin@gmail.com, eyal.birger@gmail.com, jtoppins@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next v7 2/2] Add tests for vxlan nolocalbypass option. Date: Fri, 05 May 2023 09:33:03 +0800 In-reply-to: Message-ID: <87sfcb8sej.fsf@laptop.lockywolf.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Ido Schimmel writes: > On Tue, May 02, 2023 at 12:25:30AM +0800, Vladimir Nikishkin wrote: >> Add test to make sure that the localbypass option is on by default. >> >> Add test to change vxlan localbypass to nolocalbypass and check >> that packets are delivered to userspace. > > What do you think about this version [1]? I think that your idea of making "nolocalbypass" applicable universally is more clear and more straightforward than doing an exception to a special case, as the original patch does. I had actually considered such a change myself, and only decided against it because I wanted a patch that changes the existing behaviour in a minimal way. If you are happy with a more radical behaviour for "nolocalbypass", I am all for it. I can even imagine a line in the documentation, something along the lines of "The use of the nolocalbypass flag makes debugging easier, because the packets are seen on widely available userspace network debugging tools, such as tcpdump. You might want to debug and tweak your system using this flag, and when you are convinced that the system is working as expected, turn it off for a performance gain." I will re-submit this series of patches on after the 8th of May 2023. -- Your sincerely, Vladimir Nikishkin (MiEr, lockywolf) (Laptop) -- Fastmail.